Quark Oddities

Quark Oddities

22M Downloads

Quark Config is not sorting features correctly

Phlosioneer opened this issue ยท 1 comments

commented

This code attempts to sort the modules alphabetically: https://github.com/Vazkii/Quark/blob/12e9de913e0e4e7112c36867e40f8c9c05d7cba8/src/main/java/vazkii/quark/base/module/ModuleFinder.java#L32-L34

Forge's toml config implementation (via nightconfig) does not appear to use the setInsertionOrderPreserved setting, so I think this sort is unused. Currently (Quark r2.1-243) the configs are generated in a scrambled order.

commented

This actually attempts to ensure the load order is consistent and not variable because of differences in the class loader, the purpose isn't to sort the config.