Quark Oddities

Quark Oddities

22M Downloads

LinkItem not properly sending byte[] tags.

Thutmose opened this issue ยท 2 comments

commented

I got a crash report where if a player uses the LinkItem feature to link a filled pokecube, it crashes their client when they hovor the mouse over it. I can fix this on my end with a catch block around one method, but I figured I should report this here, as the main cause is an error with the thing you use to send the itemstack in the packet.

In the itemstack's nbttag, it had the following tags (as shown by doing nbttag.toString():
EVS:[6 bytes] and IVS:[6 bytes]

these are both byte[] which were stored via tag.setByteArray

After sending the link, those tags had turned to this:
EVS:[0:"6 bytes"] and IVS:[0:"6 bytes"]

this makes it so that getByteArray returns an empty array, instead of the original one.

I have not looked through your message sending code enough to find out why, but I figured maybe you would know where this is going wrong.

commented

Closing because I'm cleaning up the issues page. This issue is really old and probably irrelevant. If you feel i should be re-opened please tell me why.

commented

na, I think it might have been fixed in the 1.12 version anyway, someone reported that they could look at my item that has byte array nbt tags in 1.12