Quark Oddities

Quark Oddities

22M Downloads

Feature Request: World Big Dungeon Dimension Blacklist: 1.15

Tyrius1 opened this issue · 5 comments

commented

Could you add a a dimension blacklist to the big dungeons config? Having some issues with them spawning in modded dimensions.

Quark-r21-245
Minecraft 1.15
Forge 31.2.33

commented

Unfortunately, due to how structures are spawned, dimension context isn't available for it. Can you specify exactly what you're having issues with?

commented

The big dungeons are generating in a new dimension mod called Tirphycraft which are imposing on the intended world gen.
I have witnessed the same issue with the Midnight mod.
(though for the midnight mod i think most would prefer if anything were changed here it just be that the dungeon use the midnight variations of stone so that it would blend in)

commented

The big dungeons are generating in a new dimension mod called Tirphycraft which are imposing on the intended world gen.
I have witnessed the same issue with the Midnight mod.
(though for the midnight mod i think most would prefer if anything were changed here it just be that the dungeon use the midnight variations of stone so that it would blend in)

You should be able to find the biome category id for all of the mod biomes--not its namespaced id--which is usually in all caps like OCEAN

Then you can use the biome blacklist using the categories.

Problem is I have a dimension mod of my own that I cannot find the biome category ids for (Undergarden)

commented

Utilizing biome type/category Is to broad an approach. For instance say a biome type in a dimension uses plains. I wouldn’t want the dungeons to also not generate in the overworld plains.

commented

You can get the dimension that the structure is trying to be placed at inside the dungeon's hasStartAt method by using the access transformer to set the world variable in ChunkGenerator to public, then comparing chunkGen.world.getDimension().getType() to DimensionType.OVERWORLD (or a list of whitelisted dimension types if you would prefer to have it configurable).

There are other ways to handle it too, such as using Placement.

I'm not sure why you wrote it off as not available? Plenty of mods do this.