Quark Oddities

Quark Oddities

22M Downloads

Matrix enchanter constantly consumes bandwidth

williewillus opened this issue ยท 0 comments

commented

Another network profiler found issue, matrix enchanter spams about 1.7K/s constantly even when idle.

It seems to be sending a packet every tick.

Breakpoint reached at vazkii.quark.oddities.tile.BaseEnchantingTableTile.sync(BaseEnchantingTableTile.java:165)
Breakpoint reached
	at vazkii.quark.oddities.tile.BaseEnchantingTableTile.sync(BaseEnchantingTableTile.java:165)
	at vazkii.quark.oddities.tile.BaseEnchantingTableTile.inventoryChanged(BaseEnchantingTableTile.java:155)
	at vazkii.arl.block.tile.TileSimpleInventory.setInventorySlotContents(TileSimpleInventory.java:115)
	at vazkii.quark.oddities.tile.MatrixEnchantingTableTileEntity.makeOutput(MatrixEnchantingTableTileEntity.java:146)
	at vazkii.quark.oddities.tile.MatrixEnchantingTableTileEntity.tick(MatrixEnchantingTableTileEntity.java:90)
	at net.minecraft.world.World.tickBlockEntities(World.java:580)

The item is empty, which makes matrixDirty true, which calls makeOutput, which calls setInventorySlotContents(2, ItemStack.EMPTY) which resyncs the tile.