Opening and closing the recipe book when equipped with a backpack misplaces the buttons

Question

Opening and closing the recipe book when equipped with a backpack misplaces the buttons

Insane96 opened this issue 4 years ago · 5 comments

Insane96 commented 4 years ago

Forge 35.1.3
Quark 2.4-276
AutoRegLib 1.6-46
https://gyazo.com/197ac008408f6c0f6b079ce46c8711ce

Vazkii · Answer 1 · 2020-12-02T04:59:55.000Z

Can you reproduce this without the mod that adds the other button?

Insane96 · Answer 2 · 2020-12-02T07:30:11.000Z

Tested without Charm, the button misplaces for a frame and then gets to the right place. With Charm the recipe button stays misplaced. Reported to Charm https://github.com/svenhjol/Charm/issues/391

F43nd1r · Answer 3 · 2020-12-02T17:11:07.000Z

@Vazkii coming over from Charm dev: BackpackInventoryScreen only stores one ImageButton/y combination. This issue would be easier fixed on quarks side by saving and restoring all present ImageButton coordinates.

F43nd1r · Answer 4 · 2020-12-02T17:39:09.000Z

Quick patch which fixes the issue:
BackpackInventoryScreen_support_multiple_image_buttons.zip

Side note: The x coordinate of our button isn't updated correctly, but that is on us.

Vazkii · Answer 5 · 2020-12-02T20:01:23.000Z

Surely PRing this is easier than sending over a zip lol

…

On Wed, Dec 2, 2020 at 5:39 PM F43nd1r ***@***.***> wrote: Quick patch which fixes the issue: BackpackInventoryScreen_support_multiple_image_buttons.zip <https://github.com/Vazkii/Quark/files/5631052/BackpackInventoryScreen_support_multiple_image_buttons.zip> Side note: The x coordinate of our button isn't updated correctly, but that is on us. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2681 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANWFL36VBMY54743WJ6OQ3SSZ3U3ANCNFSM4UGPDZTQ> .

Share to