Quark Oddities

Quark Oddities

22M Downloads

Ongoing problem with Sign Edit and Simple Harvest

volatusveritas opened this issue ยท 2 comments

commented

Sign Edit and Simple Harvest do not react to changes on their settings. I am unsure whether this is an exception only applied to these two features or if it also spans other areas of the mod, but from what I have tested, these two are problematic. Changing their settings (either through the in-game Quark menu or from the config file) does not alter their behaviour. For example: disabling Sign Edit does not disable it at all. In the same fashion, disabling Simple Harvest does not disable it at all. From what I've seen, this has been a problem since (at least) 2017. From the changelog it appears there has been no update on this as well.

In a previously reported issue the disclosure had @Vazkii saying:

I'll look into changing the sign open prompt to be server side only.

This seems to have taken effect, as disabling the config option on my server denies me the ability to edit the sign. Specifically, I receive a message in the likes of:

[13:28:31] [Server thread/WARN] [net.minecraft.server.MinecraftServer]: Player Volatus just tried to change non-editable sign

But that doesn't solve it. Right clicking still opens the GUI client side and seems to trigger a sign interaction event, making me buy whatever the sign states twice, for example (while both Sign Edit and Improved Sign Edit are disabled). It also stands that enabling the "Empty Hands Required" option also has no effect.

This renders myself in quite a horrible situation: I love Quark. I love its features, each and every one of them. Even Sign Edit, but it has been hindering my gameplay. Simple Harvest also hinders my gameplay but I can simply choose to left-click and manually collect the crop and replant it; I can't do the same with Sign Edit. And my options are not many. I can not simply disable it and keep using the other features because it doesn't work. So I can go two ways: I can either disable the sign shop plugin I'm using (which was going to be a lot of fun to me and my friends on our small server) or disable the Quark mod entirely (which also takes off a lot of fun we could've had). I'm surprised to see this has been going for so long without a fix.

I sincerely don't expect this to be fixed any time soon. Not blaming anyone; we are all limited creatures. Perhaps I can do it myself once I get to the Java part of my programming journey, or so I hope. Until then, all I can do is wait.

Details:

  • Quark version: r1.6-179
  • AutoRegLib version: 1.3-32
  • Both were downloaded from curseforge and are present both on client and on server.
commented

hey there! i know this was a while ago, but i seem to be having a similar issue on my server... we were having trouble trying to apply glow ink to the signs with Sign Edit turned on, so i set it to require empty hands. i set both the server and the client to require empty hands, but when i tried to right click the sign with the ink, it still opened up the edit interface. so i set Sign Edit to false, and if i try to edit the sign with empty hands, it's locked, but when i right click with an item in my hand, it allows me to edit the sign. i tried regular right click and shift+right click, and in both instances with empty hands, i can't edit, but with items in my hands, i can. O_o

i'm sorry to dredge up this old issue, and i know you're working on 1.20 now, so hopefully 1.19 isn't end-of-life. i appreciate all of your hard work and as above, this is no great rush. please let me know if there is anything at all that i can help with!

Details:

  • Minecraft: 1.19.2
  • Forge: 43.3.0
  • Quark: Quark-3.4-418
  • AutoRegLib: AutoRegLib-1.8.2-55
commented

curiously, it looks like with Sign Edit turned off and Requires Empty Hands turned on, both on the server and the client, i can apply ink to Supplementaries hanging signs, but not regular flat signs. on regular signs, it just opens the editing interface. fascinating!