Quark Oddities

Quark Oddities

22M Downloads

Beacon Beams are extremely laggy with extremely large worlds

GiantLuigi4 opened this issue · 1 comments

commented

image

Spark: https://spark.lucko.me/xJXPKlzqhz
While both of these are 1.18, it's the same in 1.19

Beacon's going from y=0 to ~y=8192
My advice is to check the heightmap to make sure the start block of the beam is not the highest block in the world, and if it is, terminate the beam segmentation early and instead do some special rendering logic

commented

Also, keeping the spark in mind and reading through the code a bit

Wouldn’t switching this list for a HashSet perform better?
I haven’t dealt with LinkedArrayLists much, but based off google, I don’t see any reason to use that over an ArrayList, since you never remove elements
Also, with a HashSet you’d be able to just do if (!add) break

I don’t see any reason why order is important, since the only operations used on that list are add and contains