Quark Oddities

Quark Oddities

22M Downloads

Compatablity issue with a couple IC2 Classic sawmill upgrades with quark installed alongside it

DAONE33 opened this issue ยท 4 comments

commented

First of all thanks you for makeing all the amazing small changes in Quark cant play my modpacks without it.

the issue it related to these 2 items the efficeint sawblade upgrade is supposed to give 10 planks per logs cut

and the durable sawblade upgrade give 8 planks per log

when i have quark installed and id2 classic they only give 6 planks regardless of the uprgrades mentioned above
2023-04-12_10 51 18
![2023-04-12_10 51 15](https
[latest.log](https://github.co
2023-04-12-1.log.gz
m/VazkiiMods/Quark/files/11209960/latest.log)
://user-images.githubusercontent.com/130311719/231422540-30c2d4d5-42d3-4f15-a940-b0ba3acff728.png)
2023-04-12_10 51 59
2023-04-12_10 52 01
with quark and ic2 classic

the image with six planks is with quark installed
the 2 at the top is without quark installed that how they should work

commented

Not sure why this would happen. Have you asked the IC2 team?

commented

Not yet i can and will if you think it worth mentioning to them. i just thought the fact it works as intended when uninstalling quark something was modifying it within quark. but as mentined the qulity of live feature quarks adds i cant live without :)

commented

@Vazkii How do you register Log/Plank Conversion Recipe?
Because IC2C in this case is using the Crafting Manager to find the right plank output and then converts it into a recipe that makes this work.

From what i am gathering I think this neither A Quark or IC2C bug.
What is most likely happening here is that this is a datapack recipe, which doesn't have access to this Sawmill output code.
Resulting in Quark Logs not getting upgrade boosts.
I might have to change that at some point, but the idea is that log recipes by default should be detected and work.

@DAONE33 are you the modpack author? And if not do you know who made the modpack and tag him here too?

Edit for Vazkii:
The code i am using to detect the sawmill output is effectively the same as the one from Thermal Expansion one.
Simply make a temp crafting grid, try to craft the output and the result of that output is being used for the sawmill output.

So nothing special here, and it should provide the greatest compat possible without hardcoding every single recipe.

commented

i am the person who flung the mods together so aplogies if i added something that may have caused the issue however when i tried to replicate the issue again on the lastest with just quark and ic2 on a fresh proflie / modpack with curse forege app it does not seem to happen on the that one