Quark Oddities

Quark Oddities

Mods
22M Downloads

Game crashes after changing Quark feature

qznfbnj opened this issue · 2 comments

commented

I know I can edit the config file to turn this feature on instead, but... if I'm not the only one who crashes when editing it in-game, it would be better to avoid having everyone using it crash once and then switch to editing the config file.

Mod List

1.19.2-Forge_43.3.2
AutoRegLib-1.8.2-55
Quark-3.4-410 ~ Quark-3.4-418

When changed while keybinds not existed

image

from disabled to enabled

Game crashes. Keybinds will exist after next startup.
debug.log
crash-2023-09-29_12.28.29-client.txt

Minecraft_.1.19.2.2023-09-29.12-28-26.mp4

When changed while keybinds existed

image

from enabled to disabled

No crash.

123456.mp4

from disabled to enabled

No crash.

Minecraft_.1.19.2.2023-09-29.12-38-25.mp4
commented

Thanks for the report. It looks like NarratorReadoutModule only registers its keybindings if the module is enabled at startup:

Quark/src/main/java/vazkii/quark/content/experimental/module/NarratorReadoutModule.java

Lines 50 to 55 in 9c3db1e

public void registerKeybinds(RegisterKeyMappingsEvent event) {
if(enabled) {
keybind = ModKeybindHandler.init(event, "narrator_readout", null, ModKeybindHandler.MISC_GROUP);
keybindFull = ModKeybindHandler.init(event, "narrator_full_readout", null, ModKeybindHandler.MISC_GROUP);
}
}

Whereas other modules always register their keybindings:

Quark/src/main/java/vazkii/quark/content/tweaks/module/LockRotationModule.java

Lines 84 to 86 in 36810e9

public void registerKeybinds(RegisterKeyMappingsEvent event) {
keybind = ModKeybindHandler.init(event, "lock_rotation", "k", ModKeybindHandler.MISC_GROUP);
}

so NarratorReadoutModule should probably be changed to match the other modules.

commented

not sure why this was never fixed, I just removed that enable condition check

  • 🎉1