Quark Oddities

Quark Oddities

22M Downloads

ASM hook to renderEnchantedGlint is too lenient with its selector

yrsegal opened this issue ยท 1 comments

commented

https://github.com/Vazkii/Quark/blob/master/src/main/java/vazkii/quark/base/asm/ClassTransformer.java#L184

When LibLib inserts its glowing hook into the renderEnchantedGlint, it uses an INVOKESTATIC to invoke its asm hook. Quark then crashes because it finds my INVOKESTATIC first.

commented

(tldr; check signatures)