Mixin Error in Dev Environment
PssbleTrngle opened this issue ยท 2 comments
This line here causes issues when quark is included as a dev dependency alongside some other mods, in my case Create.
It force-loads all mixins, even those that have (and should not have been) loaded yet. With the newest create >= 6.0 version this breaks when trying to run in dev, since it force-loads the FluidInteractionRegistry, due to Create's new FluidInteractionRegistryAccessor mixin at a time where it is not ready to load yet, since the ForgeMod.LAVA_TYPE registry object is not present yet.
This always results in a null crash.
I don't know if this is something you want to fix or even consider changing or if you rely on it in the dev environment, but it at least makes it impossible to depend on both create and quark for another mod.
I have also noticed that the syntax is a bit different on the master branch, but I doubt that it changes it
For now I made it work by mixing into the Quark class with a mixin that is only applied when in dev environment, but obviously this is pretty hacky:
import com.llamalad7.mixinextras.injector.ModifyExpressionValue;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.violetmoon.quark.base.Quark;
@Mixin(value = Quark.class, remap = false)
public class QuarkMixin {
@ModifyExpressionValue(
method = "<init>",
at = @At(value = "INVOKE", target = "Lorg/violetmoon/zeta/util/Utils;isDevEnv()Z")
)
public boolean noMixinAudit(boolean original) {
return false;
}
}