Quark Oddities

Quark Oddities

22M Downloads

Some requests for Quark's APIs

asiekierka opened this issue ยท 9 comments

commented
  1. Add capability support for Quark's TileEntity/ItemStack APIs. Mostly thinking of IDropoffManager here.
  2. Speaking of IDropoffManager, is it possible to add a default method which lets me give it a custom IItemHandler?
commented

2 is acknowledged and will be in the next release. I'll leave 1 for later.

commented

Okay! I was thinking of adding dropoff support to my barrels, that's why I was asking. (Would it be a good idea?)

commented

Knock yourself out. I just won't do 1 right now because I don't have a lot of time on my hands to learn the capability system too well. If you want to PR it that would be appreciated.

commented

Don't have much time myself (January is the month of incoming finals over here), sorry! But hey, at least it's acknowledged.

commented

How's this?

commented

Nevermind, that only does it for one case. Give me a sec >_>

commented

@Vazkii That's terrible.

Say, SlotItemHandler. The inventory won't help much here. Make two methods - one passes the TileEntity (for the other case), the other passes... something else. The container the player has open, maybe? The slot?

commented

Ok I think this one should work well enough?

commented

Yes, except I'd still add separate support for SlotItemHandlers over just checking slot.inventory (or, better yet, allow implementing IDropoffManager on the Container object itself?). Other than that, though, this should be good, and is definitely good enough for what I had in mind!

Though I do still depend on #736 ...