Quark Oddities

Quark Oddities

Mods
22M Downloads

[1.12.2] Visual Stat Display catches wrong tooltip

TheIllusiveC4 opened this issue ยท 2 comments

commented

Particularly, this function: https://github.com/Vazkii/Quark/blob/a0dbd0c69ae00bca778487ac36982fa17480e02c/src/main/java/vazkii/quark/client/feature/VisualStatDisplay.java#L69-L75
My mod, Construct's Armory, has a tooltip that describes the different parts of the armor. One of these parts is "Armor Plates". Since it contains the word "Armor" and comes before the stats, Quark removes this tooltip instead of the correct one further down the list. The result is a missing tooltip for Construct's Armory and a hanging "Armor" stat tooltip from vanilla.

screenshot

Versions:

  • Quark: Quark-r1.4-123
  • ARL: AutoRegLib-1.3-16
  • Forge: 1.12.2-14.23.3.2655
commented

Yeah that checking method was incredibly naive. I'll replace it with a regex.

commented

This is the same bug, I think.
Btw. can you add a config option, to disable this little overlay tooltip?
weapon bug