Quark

Quark

143M Downloads

Suggestion: Add chat printing to the sleep vote system

katubug opened this issue · 7 comments

commented

Hello! Firstly, thank you for making and maintaining this invaluable mod. It's greatly appreciated!

So, my server has removed Morpheus in favor of using Quark's sleep vote system, because Morpheus counts all players, regardless of afk status. However, one feature that we've been missing is the chat indication that someone wants to sleep through the night and needs others to join.

I'm not sure if this is something that you would be interested in adding, but I thought I'd make the suggestion nevertheless. Thanks for your time!

commented

@Vazkii Is this something we should do?

commented
commented

We haven't been getting any chat messages when someone sleeps. Can anyone else confirm? The issue might be on my end.

commented

Could you pass us a log, in which you try to sleep with other players online?

commented

Sure! Although it occurs to me, perhaps it's not printing to chat because it's just progressing to morning? My required percentage is set to 25% and there were four people online when I tried to sleep. Is that why?

For posterity, here are the logs, but there's nothing of note in them.

Client latest.log: https://hastebin.com/ejusozefur.md
Server latest.log (partial because the full version was too big for hastebin): https://hastebin.com/meremehuca.md

It's at the very end, you can ctrl+f for "Sweet dreams."

commented

Just wanted to say that we tested it this time with 5 players online and it did print correctly. "[player] is now sleeping. (1/2)"

Sorry to take up your time!

commented

Well, this fix makes the underlying code better either way, so it was worth the report!