Quark

Quark

143M Downloads

flowerpot missing texture / not working right

WarlordWossman opened this issue ยท 23 comments

commented

So I got the better vanilla flower pot feature on but the colored flowerpots turned off and I get this effect when placing the normal flower pot:
fp_3

It also seems like comparators cannot read from this flower pot, even if I couldn't really see if the flower was placed in it, the character did a hand swing which suggests something happened but you never know.

Here is the setup:
fp_1
fp_2

It seems to me like the comparator option should be under the better vanilla flower pots config and not under the colored ones.

commented

Do you have liteloader installed? That is known to cause issues with registry substitutions, which is what the better flower pot uses.

commented

Please provide a log.

commented

Do you have liteloader installed? That is known to cause issues with registry substitutions, which is what the better flower pot uses.

no liteloader installed

here is the log:
https://gist.github.com/WarlordWossman/9521af26736af6a6171f3c5c0581eaad

commented

it's a forge port recently released or could that also be a reason, def not using liteloader in this instance lol

commented

could you use f3 and show us what the visual display of the blockstate shows?

commented

2019-07-24_16 13 06

commented

w-what the

what in the entire fuck

commented

haha, not sure if it would matter but I had the colored ones turned on for a while and decided to toggle them off because the items in my pack were becomming too many.
I can also try maybe just toggling off the better vanilla flower pot and see if it works, then re-enable and see if it works after, gonna test a little more!

commented

try all of those combinations, and report back! thanks for doing the testwork

commented

try all of those combinations, and report back! thanks for doing the testwork

np, thanks for really taking those small things serious btw <3

okay so disabling and re-enabling led to the same result which is this weird air blockstate, flower pots were fine with the "better vanilla flower pots" feature turned off tho.
I also tried breaking the block under this bugged "flower pot" and it does correctly drop the flower pot as an item, I am not quite sure what is going on here.

another test just to make sure: turning on the colored versions of the flower pots didn't fix the default one behaving like this.

commented

What happens if you use setblock to place a flower pot?

commented

What happens if you use setblock to place a flower pot?

good idea, setblock commands actually place the right flower pot that also seems to fuction normally and give a comparator output!

commented

Litematica is a liteloader mod, though...

commented

So somehow the flower pot item is placing the wrong flower pot block. Can you test the Inspirations version of the same feature? It could be related to how we both do registry substitutions differently

commented

Don't have inspirations installed so that shouldn't be the issue.

commented

He was asking you to acquire another data point.

commented

He was asking you to acquire another data point.

I don't really get it tbh, does inspirations have exactly the same feature or what?

commented

Inspirations does registry replacement as well, for the cauldron, but KnightMiner does it differently than we do.

commented

Inspirations also has the flower pot feature, I PR'ed it in as a copy of the Inspirations one. Hence, I want to see if his issue happens with my copy as well.

commented

Ah, now I see, sorry for being confused at first :D

Just tried with inspirations (obv quark feature turned off, and the inspirations betterflowerpot on) and getting the same result.

commented

So, I am still nearly certain this is a conflict, some other mod is either changing flowerpots or hacking into registries. Can you reproduce this with just Quark? If not, can you try to find the combination of mods required?

A common trick is take out half your mods at a time and see if the issue happens. If so you've removed half the mods, if not the issue is in the other half

commented

It probably is a conflict if others don't get this bug, I will see if I find the motivation to find the mod interaction that might cause it - does take some time even with 50/50 strat.

For now I just disabled the feature.

commented

Also, while you are testing, assuming this is the same as the LiteLoader issue (despite no LiteLoader), you could try installing the mod mentioned here. I'm banking on Litematica being the problem though, if it's a recent forge port there is a chance they just copied all of liteloaders ASM, some of which causes this bug.