Quark

Quark

Mods
143M Downloads

1.14 beta - pushing a block occupying a spot where a TE was previously pushed tries to render the TE again

Hubry opened this issue ยท 0 comments

commented

Reproduction: Place a sticky piston, put any TESR-using block (like a chest, or an enchanting table if you remove it from the blacklist), power and unpower the piston, replace the TE block with a block that doesn't have one (Slabs show the enchanting table issue very clearly), power the piston again.

Result: If the block doesn't have any special blockstate properties used by the TE renderer, it will render it while moving (as seen with the enchanting table). Otherwise, the chunk will flicker and it will throw an exception, like:

[Client thread/WARN] [quark/]: minecraft:end_stone_brick_slab can't be rendered for piston TE moving
java.lang.IllegalArgumentException: Cannot get property DirectionProperty{name=facing, clazz=class net.minecraft.util.Direction, values=[north, south, west, east]} as it does not exist in Block{minecraft:end_stone_brick_slab}
	at net.minecraft.state.StateHolder.func_177229_b(SourceFile:95) ~[?:?]
	at net.minecraft.client.renderer.tileentity.ChestTileEntityRenderer.func_199341_a(SourceFile:70) ~[?:?]
	at vazkii.quark.automation.client.render.PistonTileEntityRenderer.renderPistonBlock(PistonTileEntityRenderer.java:47) ~[?:beta-2.0-181]
	at vazkii.quark.base.handler.AsmHooks.renderPistonBlock(AsmHooks.java:92) ~[?:beta-2.0-181]
	at net.minecraft.client.renderer.tileentity.PistonTileEntityRenderer.func_199341_a(PistonTileEntityRenderer.java) ~[?:?]
	at net.minecraft.client.renderer.tileentity.PistonTileEntityRenderer.func_199341_a(PistonTileEntityRenderer.java:24) ~[?:?]
	at net.minecraft.client.renderer.tileentity.TileEntityRendererDispatcher.func_203602_a(TileEntityRendererDispatcher.java:139) ~[?:?]
	at net.minecraft.client.renderer.tileentity.TileEntityRendererDispatcher.func_180546_a(TileEntityRendererDispatcher.java:117) ~[?:?]
	at net.minecraft.client.renderer.WorldRenderer.func_215326_a(WorldRenderer.java:601) ~[?:?]
	at net.minecraft.client.renderer.GameRenderer.func_181560_a(GameRenderer.java:713) ~[?:?]
	at net.minecraft.client.renderer.GameRenderer.func_78471_a(GameRenderer.java:640) ~[?:?]
	at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:494) ~[?:?]
	at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:887) ~[?:?]
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:384) ~[?:?]
	at net.minecraft.client.main.Main.main(SourceFile:155) ~[1.14.4-forge-28.1.10.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_181]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_181]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_181]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_181]
	at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:56) ~[forge-1.14.4-28.1.10.jar:28.1]
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-3.2.0.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:50) [modlauncher-3.2.0.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:68) [modlauncher-3.2.0.jar:?]
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:80) [modlauncher-3.2.0.jar:?]
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:65) [modlauncher-3.2.0.jar:?]

Using AutoRegLib-1.4-34, Quark-beta-2.0-181, Forge 28.1.10.