[1.16] Reloading config is not thread safe
BloCamLimb opened this issue ยท 0 comments
Description: Forge's ConfigWatcher works on separate threads, and Quark is calling NewChatGui
methods on that thread which leads to a potential thread safety issue.
Relevant Code: /vazkii/quark/base/proxy/ClientProxy.java
Versions: ALL
Suggested Solution: Replace with mc.runAsync(Runnable)
Additional Notes:
- The root of the issue is that it calls the font renderer, which should work on the Render thread.
- The
senderUUID
param inplayer.sendMessage()
is not used inClientPlayerEntity
, so there is no need to new a randomUUID
object, just passnull