Quark

Quark

143M Downloads

[1.16] Reloading config is not thread safe

BloCamLimb opened this issue ยท 0 comments

commented

Description: Forge's ConfigWatcher works on separate threads, and Quark is calling NewChatGui methods on that thread which leads to a potential thread safety issue.

Relevant Code: /vazkii/quark/base/proxy/ClientProxy.java

Versions: ALL

Suggested Solution: Replace with mc.runAsync(Runnable)

Additional Notes:

  1. The root of the issue is that it calls the font renderer, which should work on the Render thread.
  2. The senderUUID param in player.sendMessage() is not used in ClientPlayerEntity, so there is no need to new a random UUID object, just pass null