[Question] About false config not disabling features
HipHopHuman opened this issue ยท 11 comments
I've installed Quark (and Oddities) into a 1.15.2 pack I'm making. The theme of the pack is Vanilla, but with more "polish" instead of more features. So it's not a Vanilla+ pack, more like a Shiny Vanilla +- pack. If that makes sense. As per the theme, I have to be rather strict with the features I include. I don't want all the features Quark offers, just a select few. I've disabled a lot of it in the config. I noticed that these features still appear in the creative menu, which is fine, but some disabled features actually still generate in the world. For example, if I disable the extra stone types (jasper, marble, etc), I still find them generating in caves.
I've read this and this raises a few concerns and questions for me. Specifically this part:
This is intentional. As of 1.13, mods are encouraged to keep all the content in even if disabled.
My first concern: Am I simply not understanding this sentence right? There are configs to disable features, but the features still generate in-game. How is having a config that does nothing intentional? I must be misinterpreting this sentence - when you say it isintentional, are you referring to just items and blocks being registered; but not necessarily showing in game; or does this include world generation?
My second concern: You say it is encouraged - encouraged by who? Forge? Mojang?
I apologize in advance if I come across as a little hostile here - I'm not trying to be, it is just simply the way I communicate as I generally struggle with thinking of gentler ways to say things or get my point across.
Disabled stone types generating is definatly a bug. The "encouraged" behavior I believe is having disabled blocks/items/features not generate or be obtainable in any way, but still be registered and maybe show up in the creative inventory / JEI.
As of 1.13, Forge feature standards request you keep every piece of content available but "hidden", so that features can be hotswapped in real time, which quark allows.
The features will still be in the game, and will show in creative (unfortunately due to vanilla behaviour, I wish I could remove them too), but recipes and other methods of acquisition or generation will be disabled, so you don't have to worry about that.
but recipes and other methods of acquisition or generation will be disabled
Shouldn't this be left open then, as disabled stone types seem to be generating?
You're right, I missed that. @HipHopHuman can I have a copy of your config?
@Vazkii Sure, sorry it took so long, had a busy day. Here's the config if you need anything else (debug.log, etc) just let me know
(also, I'm not as phased about items appearing in the creative menu. im sure someone somewhere can be paid enough shillings to make a mod that goes over and hides that, or i could just use JEI and crafttweaker to hide recipes/items)
Seems like all the stones are enabled in your config: https://gist.github.com/HipHopHuman/ab5ddb0f90b62f26c3b0eaf1e3f8741c#file-quark-common-toml-L754-L759
@Vazkii Are you sure? I thought world["New Stone Types"]
would override that. https://gist.github.com/HipHopHuman/ab5ddb0f90b62f26c3b0eaf1e3f8741c#file-quark-common-toml-L397
I see what's happening here, I marked it in #2482. I recommend you disable the ones I also marked.
@Vazkii Forge config on 1.15 is weird, disabling those configs worked, so thanks for the help and putting up with me. Here is a cursed image from my modpack to show my appreciation