Quark + Chat Heads = Incorrect Icon Offset
Brittank88 opened this issue · 6 comments
Quark seems to assume that the chat is not being offset from the left by any amount. This means that when something like ChatHeads is installed, and [management.item_sharing] => "Render Items In Chat" = true
, the icons appear behind the text:
Considering that the Chat Heads icon is a set size (I'm pretty sure, at least...), would it be possible for Quark to check for the mod's presence and account for this?
A more elegant solution would involve positioning based on the position of the surrounding text, though, I don't know how difficult that is to achieve.
Regardless, thanks for your time!
Client log
Quark version: r2.4-295
AutoRegLib version: 1.6-47
Minecraft version: 1.16.4
Forge version: 25.1.37
Hello! Quark's moved to 1.18 now-- unfortunately, this means that (unless your bug is critical and/or game-breaking), we're closing support for issues filed for versions prior to it (e.g. Quark on 1.16).
If your issue still occurs on 1.18, or if your issue happens to be rather critical (e.g. consistently crashing the game with no other mods present), please leave another note or open a new issue. Thanks for your cooperation!
P.S. Is it worth me approaching the Chat Heads dev to see if that mod can offset the Quark item icons instead?
Probably related to this: If gui scale is not set to auto, icons are vertically and horizontally misplaced
Hey, back here just to see if it would be possible to say, just increment the X pos of the item icon by an appropriate amount if CH is installed. It would be at least a temporary solution before a better one is eventually implemented.
The chat heads are always the same width in chat, scaled by GUI scale the same as any other character.
Maybe I'm missing something - I was looking at the source code for rendering items to see if I could figure out why what I'm suggesting wouldn't work, but I'm not sure.
At the very least, if some public offset variable was exposed, I could use KubeJS's reflection capabilities to customise that value as necessary, at my own risk. Currently, there's nothing I can do to even fix this for specifically my circumstances (I don't count disabling it as a fix, that's just avoiding the issue lol).
Would be better as a config option but at least this change would require less effort as it wouldn't even modify the config.