Quark

Quark

Mods
143M Downloads

Stoneling spawn creating lag spikes

Krampus69 opened this issue · 5 comments

commented

Hello hello 👋
I was wondering if you could help me understand : I tend to get moderate lag spikes on my server and when I use Spark to see why is it happening it says it's about stoneling spawning.
Here is my spark profiler if you want to take a look I captured a lag spike caused by that :
https://spark.lucko.me/epDsCyLRSc

I'm playing on Minecraft 1.16.5 / Forge 36.2.22 / Quark-r2.4-321
I have a setup with many mods, the lag spikes due to this stoneling spawn issue are usually not that bad (200-300ms) and don't happen very often but it still is intriguing and I was wondering if you may have an idea why this is happening :)

I'm sorry I couldn't put the log on pastebin because its size was too big so I made a .zip for you
latest.zip

You're doing remarkable work, thank you for contributing in Minecraft Modding community.

commented

I actually have no idea what would cause this, especially in that version. If it keeps happening your best bet is probably just to disable the spawning in the config for now.

commented

I too am getting some lag spikes in Minecraft 1.18.2 and Stonelings appear to be the source. Here's my profiler output: https://spark.lucko.me/Wamoi3e0Ey

commented

Same thing for me too, stonelings take up to 95% of overall tick time of laggy ticks, which is huge !
The cause seems to be the Pathfinder Module
image

https://spark.lucko.me/v2GuX8QPrT?hl=1627,359

commented

Update : It seems like FTB Backups 2 and the stonelings from Quark are incompatible, which might be due the stonelings map module.
Each time there was a backup (In my case every 30min), the server would timeout everyone because there was a 50s lag spike. Disabling stonelings from Quark fixed it for me.
(This is on forge 1.19.2)

commented

I get a similar lag spike (12-15 seconds) once every few minutes while exploring / living in a Mushroom Island biome that's surrounded by ocean for several kilometers in a Large Biomes world.
Seed: 1001816
Coordinates: /tp @s 500 80 3500
Mod pack: ATM8 1.0.4
Mod version: Quark 3.3-373, Forge 43.1.55, Minecraft 1.19.2

Try disabling "Waeld Pathfinder Maps" [sic] in the Stonelings module in the Mobs category in the Quark config file.

Offending loot table entry:

Quark/src/main/resources/data/quark/loot_tables/entities/stoneling_carry.json

Lines 141 to 170 in ba5d22b

{
"type": "minecraft:item",
"weight": 10,
"name": "minecraft:map",
"functions": [
{
"function": "quark:pathfinder_map",
"destination": "quark:stoneling_pathfinding",
"color": "#317546",
"underground": true
}
],
"conditions": [
{
"condition": "quark:flag",
"flag": "pathfinder_maps"
},
{
"condition": "quark:flag",
"flag": "stoneling_weald_pathfinder"
},
{
"condition": "minecraft:inverted",
"term": {
"condition": "quark:in_biome",
"target": "quark:stoneling_pathfinding"
}
}
]
}

Spark profile of a tick that took 13.8 seconds, mostly spent running /locate biome caused by a Stoneling spawning with a Waeld Pathfinder Map: https://spark.lucko.me/kSsmthI8W4