Quark

Quark

143M Downloads

[1.18.2 3.2-349] Quark chest variants are not replacing chests in Repurposed Structures mod's structures

TelepathicGrunt opened this issue ยท 1 comments

commented

I am using Quark-3.2-349 with repurposed_structures_forge-5.1.4+1.18.2 and have visited several structures from my mod. None have their chests replaced despite their configuredstructurefeature names being correct here in the BUILT_IN_MOD_STRUCTURES list:

"repurposed_structures:bastion_underground=quark:dark_oak_chest",
"repurposed_structures:city_nether=quark:nether_brick_chest",
"repurposed_structures:fortress_jungle=quark:jungle_chest",
"repurposed_structures:igloo_grassy=quark:oak_chest",
"repurposed_structures:igloo_stone=quark:spruce_chest",
"repurposed_structures:mansion_birch=quark:birch_chest",
"repurposed_structures:mansion_desert=quark:jungle_chest",
"repurposed_structures:mansion_jungle=quark:jungle_chest",
"repurposed_structures:mansion_oak=quark:oak_chest",
"repurposed_structures:mansion_savanna=quark:acacia_chest",
"repurposed_structures:mansion_snowy=quark:spruce_chest",
"repurposed_structures:mansion_taiga=quark:spruce_chest",
"repurposed_structures:mineshaft_birch=quark:birch_chest",
"repurposed_structures:mineshaft_crimson=quark:crimson_chest",
"repurposed_structures:mineshaft_desert=quark:jungle_chest",
"repurposed_structures:mineshaft_end=quark:purpur_chest",
"repurposed_structures:mineshaft_icy=quark:spruce_chest",
"repurposed_structures:mineshaft_jungle=quark:jungle_chest",
"repurposed_structures:mineshaft_nether=quark:nether_brick_chest",
"repurposed_structures:mineshaft_ocean=quark:prismarine_chest",
"repurposed_structures:mineshaft_savanna=quark:acacia_chest",
"repurposed_structures:mineshaft_stone=quark:spruce_chest",
"repurposed_structures:mineshaft_swamp=quark:dark_oak_chest",
"repurposed_structures:mineshaft_dark_forest=quark:dark_oak_chest",
"repurposed_structures:mineshaft_taiga=quark:spruce_chest",
"repurposed_structures:mineshaft_warped=quark:warped_chest",
"repurposed_structures:outpost_badlands=quark:dark_oak_chest",
"repurposed_structures:outpost_birch=quark:birch_chest",
"repurposed_structures:outpost_crimson=quark:crimson_chest",
"repurposed_structures:outpost_desert=quark:jungle_chest",
"repurposed_structures:outpost_giant_tree_taiga=quark:spruce_chest",
"repurposed_structures:outpost_icy=quark:spruce_chest",
"repurposed_structures:outpost_jungle=quark:jungle_chest",
"repurposed_structures:outpost_nether_brick=quark:nether_brick_chest",
"repurposed_structures:outpost_oak=quark:oak_chest",
"repurposed_structures:outpost_snowy=quark:spruce_chest",
"repurposed_structures:outpost_taiga=quark:spruce_chest",
"repurposed_structures:outpost_warped=quark:warped_chest",
"repurposed_structures:pyramid_badlands=quark:dark_oak_trapped_chest",
"repurposed_structures:pyramid_end=quark:purpur_chest",
"repurposed_structures:pyramid_flower_forest=quark:oak_chest",
"repurposed_structures:pyramid_giant_tree_taiga=quark:spruce_chest",
"repurposed_structures:pyramid_icy=quark:spruce_chest",
"repurposed_structures:pyramid_jungle=quark:jungle_chest",
"repurposed_structures:pyramid_nether=quark:nether_brick_trapped_chest",
"repurposed_structures:pyramid_ocean=quark:prismarine_chest",
"repurposed_structures:pyramid_snowy=quark:spruce_chest",
"repurposed_structures:ruined_portal_end=quark:purpur_chest",
"repurposed_structures:ruins_land_hot=quark:jungle_chest",
"repurposed_structures:ruins_land_warm=quark:oak_chest",
"repurposed_structures:ruins_nether=quark:nether_brick_chest",
"repurposed_structures:shipwreck_crimson=quark:crimson_chest",
"repurposed_structures:shipwreck_end=quark:purpur_chest",
"repurposed_structures:shipwreck_nether_bricks=quark:nether_brick_chest",
"repurposed_structures:shipwreck_warped=quark:warped_chest",
"repurposed_structures:stronghold_nether=quark:nether_brick_chest",
"repurposed_structures:temple_nether_basalt=quark:nether_brick_chest",
"repurposed_structures:temple_nether_crimson=quark:crimson_chest",
"repurposed_structures:temple_nether_soul=quark:warped_chest",
"repurposed_structures:temple_nether_warped=quark:warped_trapped_chest",
"repurposed_structures:temple_nether_wasteland=quark:nether_brick_chest",
"repurposed_structures:village_badlands=quark:dark_oak_chest",
"repurposed_structures:village_birch=quark:birch_chest",
"repurposed_structures:village_crimson=quark:crimson_chest",
"repurposed_structures:village_dark_oak=quark:dark_oak_chest",
"repurposed_structures:village_giant_taiga=quark:spruce_chest",
"repurposed_structures:village_jungle=quark:jungle_chest",
"repurposed_structures:village_mountains=quark:spruce_chest",
"repurposed_structures:village_oak=quark:oak_chest",
"repurposed_structures:village_swamp=quark:oak_chest",
"repurposed_structures:village_warped=quark:warped_chest",

I have visited the config, restarted the game, etc and no change. I even edited in the jungle village entry and restarted game but that too failed. No matter what, it is not applying for my mod's structures. Let me know if you need more info.

image
image
image
image
image

commented

I did a test. Quark is not grabbing the configured structure feature and is instead, grabbing the base structure. Which is bad. Well heavily discouraged by even vanilla (since vanilla shows configured structure features in their locate command and uses tags that targets configured structure features. They dont do much with targeting the base structure anymore it seems)
image

The main reason why this is no good for Quark's config is because base structures can be used to create many kinds of configured structures. Vanilla uses the jigsaw base structure to create the 5 types of villages.

In this case with Repurposed Structures, I use the Generic Jigsaw Structure class to create many of my configured structure features. Currently, users have no way of targeting just my swamp village instead of all my villages as if they try to put "repurposed_structures:generic_jigsaw_structure" into quark's config, it'll replace the chest of like 70% of all my structures.