Quark

Quark

Mods
143M Downloads

[1.18.2][Compatibility] 'Item Sharing' module is not compatible with Chat Heads

qznfbnj opened this issue · 1 comments

commented
  1. Install Forge-1.18.2-40.1.52
  2. Install chat_heads-0.6.0-forge-1.18.1 alongside Quark-3.2-358
  3. Startup and crash

If comment out "client.ChatComponentMixin" in quark.mixins.json, game can run normally. But 'Render Items In Chat' function in 'Item Sharing' module will render nothing.
chatheads-quark
Because I can't figure out whose fault it is, I will submit to another at the same time: dzwdz/chat_heads#28.

Useless stuff:
Latest.log
Debug.log
Crash Report

commented

Chat Heads maintainer here, I fixed this on our end.

The issue was that Chat Heads targets the Font.drawShadow call that ChatComponentMixin redirects, so when Quark's mixin is loaded before Chat Heads' mixin, it won't be able to find the method.

Quark's @Redirect could be replaced by a @ModifyArgs for better compatibility, but it would make the code uglier (and a little bit less efficient), hence I just opted to adjust the Mixin priority on our side.

  • 👍1