Quark

Quark

143M Downloads

Sorting Feature Deletes Items in Mod Containers

Blunder-G opened this issue · 12 comments

commented

Sorting feature deletes the items in a Cabinet from Farmer's Delight

Log gist: https://gist.github.com/Blunder-G/c229accdb947739e3541644160cb99ad

Me showing the bug in game: https://streamable.com/nzffd9

commented

I have had inventory sort clear 3/4 of my inventory 1.18.2 as well as having it happen with world gen chests(though not as common) - latest.log https://gist.github.com/HumanF91R/dfe92a945518915f0199ffbe304e7747

commented

A Similar Bug with Sophisticated Backpacks: #3674

commented

Have also run into this bug while using the sort items feature in Quark Storage Crates. Watched roughly half of its inventory disappear before my eyes.

Not sure if this crash report will be helpful or not:
crash-2023-05-13_18.12.52-client.txt

commented

Disable sorting in the short term to be safe. I’ll investigate tomorrow.

commented

Hi, we've had some issues with this on our server - are there any eyes on this issue or should I disable sorting for now?

commented

Thanks so much! Will do.

commented

@Arialla-Fio Do you have an example of a crate inventory that will cause this?

commented

Disable sorting in the short term to be safe. I’ll investigate tomorrow.

@yrsegal if you want please can you also check this issue: #3674, this bug has been open for over a year but still hasn't been fixed or answered

commented

@Arialla-Fio Do you have an example of a crate inventory that will cause this?

I don't think I have any logs at this point, but I can say that I had made the mistake of putting stackable items in the crate. So an example might be a bunch of non-stackable gear items like armor pieces, weapons, and spare flint & steels, plus stackable things like arrows and various loot items. Another crate I had things get deleted from had a bunch of saplings, flowers, seeds, crop items, a hoe, fertile soil, and bonemeal that I had shoved into a crate until I could get crop farms built and into a proper storage system.

So far (crosses fingers) I have not had anything disappear from a crate that only contains music disks, nor from one that only contains armor pieces, or one that contains only tools & weapons.

I have also had things disappear from other types of containers when using the middle mouse click item sorting, but I'm not sure if this is related.

commented

Just as an addendum, I believe the middle click sorting that Ari mentioned is from Inventory Sorter, as we have both in our modpack.

commented

I haven't been able to replicate this, so I can't investigate to find a solution.

commented

I haven't been able to replicate this, so I can't investigate to find a solution.

I have been able to replicate another instance of the sort button deleting items in player inventory, its possible that the same thing is causing others issues.
Somehow, through a yet unknown loot table zombies drop 2 stone axes stacked together. when the sort button is pressed the iron axes get separated and the second axe gets destroyed, however all other items after it get destroyed as well.
I assume this may be due to the zex trying to go to the next slot but returning a null, which breaks the sequence for the remaining items. In my archaic programming days we had issues of programs dropping the array from memory when and incompatible value existed within, I'm not sure if this is the same.