Quark

Quark

143M Downloads

Item description menu overlap bug

Endmateria opened this issue ยท 5 comments

commented

Quark is causing a description menu bug with other mods. I've noticed it with both Actually Additions, and Underwater Utilities. Original issue: shadowfacts/UnderwaterUtilities#16
Here's a pic of glitched item description window... https://ibb.co/cwZqwQ

You can reproduce this bug with the following mod setup...
Minecraft 1.11.2
-Forge 2282

(Quark)
-AutoRegLib 1.1.4
-Quark 1.2-90

(Underwater Utilities)
-Forgelin 1.4.1
-ShadowMC 3.7.5
-Tesla 1.3.0.52
-Underwater Utilities 1.2.3

Also, you can substitute the above "Underwater Utilities" mod setup with the Actually Additions file/mod 1.11.2-r106 and find the same bug here... https://ibb.co/inUvVk

commented

I'm actually closing this one, because if this is happening, it means the mods are firing the tooltip render event, but not the tooltip contents event, which causes the empty line to not be added.

commented

So though it's triggered by your mod, the solution is for the affected mods to add this event on their ends? I mean, it's not a game breaking bug, but if it's an easy solution then I can go through JEI, find all of the culprits in my mod setup, and direct all these mods/mod authors to an appropriate fix... cuz I've seen this is affecting other mods as well (besides the original two I mentioned).

commented

The issue is the mod that calls the tooltip render, not the mod that provides the contents.

commented

Understood

commented

I'm pretty sure JEI is calling everything correctly when you hover over an item here.

First I call itemstack.getTooltip which fires ItemTooltipEvent.
Then I add the formatting to it like vanilla does.
Then I add the mod name on to the end of the list if it's not there already.
Finally I call GuiUtils.drawHoveringText to draw the tooltip, which is a Forge utility and calls the appropriate events.

Did I go wrong somewhere? I'm not sure how the armor tooltip thing works.