Quark

Quark

143M Downloads

Quark breaks the fire resistance on the netherite outfit introduced in the latest Create update

JAWredstoneguy opened this issue ยท 2 comments

commented

Create is version 0.5.1.a for 1.19.2
Quark is version 3.4-400 for 1.19.2
AutoReglib is version 1.8.2-55
Forge is version 43.2.4

This is the log for the version without Quark;
https://pastebin.com/XguFFF7k

This is the log for the version with Quark;
https://pastebin.com/i93nujKB

How to replicate;

  • Install Quark and Create and hop into a world.
  • put on the netherite back tank, netherite diving helmet, netherite diving boots, and netherite leggings.
  • Hop into a pit of lava

What's expected to happen;
You should not catch on fire and take damage, and be able to walk around in the lava unscathed.
2023-05-22_13 18 28

What actually happens;
You catch fire, and start to take damage.

2023-05-22_13 58 30

commented

Both mods inject into Entity#fireImmune() at RETURN, with both mixins using the default priority. Quark sets the return value regardless of the initial value, which causes the method to return instantly and ignore Create's injector if it was placed after Quark's. If Create's injector is placed before Quark's, it will cause pickarang fire immunity to break.

Since there is no way to set the return value without returning, the mixins in both mods should only set the return value when it differs from the current value. If Quark is not updated for 1.18, Create can work around this by making sure its injector runs before Quark's.

commented

oh joy. more bugs I gotta watch out for if I can even update my create cause of all the addons being bust. >_>'