Quark

Quark

143M Downloads

Pickarang can break reinforced deepslate

LeoBeliik opened this issue · 4 comments

commented

it shouldn't (?)

commented

I thought reinforced deepslate was indestructible, but nah it just takes 80 seconds to mine regardless of tool lol

We could specifically denylist reinforced deepslate, or add an epsilon to the getBlockDestroyProgress check to forbid blocks that get mined too slowly

commented

Epsilon sounds like a good plan. Didn’t we have that, set to forbid Obsidian? Or was that some other parameter?

commented

pickarangs can't mine obi (by default) or any sculk block

commented

something seems suspect with the "equivalentHardness" computation

float progress = getBlockDestroyProgress(state, player, level(), hit);
if(progress == 0)
return;
float equivalentHardness = (1) / (progress * 100);

[21:30:36] [Server thread/INFO] [quark/]: state: Block{minecraft:obsidian}, progress: 2.0E-4, eqHardness: 50.0
[21:30:47] [Server thread/INFO] [quark/]: state: Block{minecraft:reinforced_deepslate}, progress: 6.060606E-4, eqHardness: 16.5

reinforced deepslate has a lower "equivalent hardness" than obsidian

Blocks.OBSIDIAN: .strength(50.0F, 1200.0F)
Blocks.REINFORCED_DEEPSLATE: .strength(55.0F, 1200.0F)