Quark

Quark

143M Downloads

Unsafe cast with forge IConditions in Zeta Conditions bridge

MehVahdJukaar opened this issue ยท 1 comments

commented

Whatever is going on here is wrong. Prob better if whoever coded this would fix it.

protected <THEIR_CONDITION extends ICondition, MY_CONDITION extends IZetaCondition> MY_CONDITION fromForgeCondition(THEIR_CONDITION theirs) {

Noticed cause of usafe cast crash that happened with every compat. Should be unrelated to it tho.

Maybe wouldnt it be better to have some simple helper methods for this stuff instead of wrapping all this forge code given the limited use and the fact that even tho fabric has a similar system both would need to be added to jsons to be effective kind of defeating the propose of shared assets.

commented

Fixed by VazkiiMods/Zeta#1 , implemented a lot simpler and doesn't have any unchecked casting.

This is pretty much useless forgecruft, although some of it is required to interact with the Forge recipe conditions system in the first place.