
Attribute tooltip does not work in Percentage mode for multiply attribute modifiers
Lykrast opened this issue ยท 0 comments
Minecraft 1.20.1
Neoforge 47.1.104
Quark 4.0-462
If you have an attribute in the attribute tooltips that's on "percentage" display mode and something that applies a multiply_base/multiply_total value to it, that change won't display in the attribute tooltip.
I suspect because of
I'm not sure if I'm clear so I'll explain what I'm trying to do:
- Want to add compat with my attributes (in Guns Without Roses) like Botania did.
- I got attributes with a base value of 1 that are multipliers, and I got potions that modify them (and armors in an unreleased addon)
- Ex:
this is a multiply total attribute modifier (it's red cause no way in vanilla to say "lower = good" until I think 1.21?)
- In multiplier mode this is calculated fine (placeholder icon)
- In percentage it does not show up, but I want it to say -20% (like how the vanilla tooltip says it)
- Difference makes it display as -0.2, not what I want
Iron's Spells and Spellbooks's spell_power
attribute is in a similar situation on its armors (would like to display a +5% like the vanilla tooltip, but percentage won't display and difference is like +0.05).
Side note I think it's also not parsing the "compare": "lower_better"
because setting that on the attribute, the attribute comparaison still prefers the higher number (here armor from that unreleased addon vs diamond pants).



And just to be clear the relevant part of my attributes_tooltips.json
"gunswithoutroses:gwr.fire_delay": {
"display": {
"mainhand": "multiplier",
"offhand": "multiplier",
"feet": "multiplier",
"legs": "multiplier",
"chest": "multiplier",
"head": "multiplier",
"potion": "multiplier"
},
"texture": "gunswithoutroses:attribute/fire_delay",
"compare": "lower_better"
},