[1.16.1]reload the datapack causes the command to fail
lycc193 opened this issue · 8 comments
I found nothing useful after reloading in 1.16.3 sadly, only this
reload
Reloading!
Registering 1 commands.
Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
Reloading ResourceManager: Default, PumpkinPotions-1.16.3-1.0.3.jar, cucurbita-1.16.3-1.0.13.jar, forge-1.16.3-geckolib-2.1.2.jar, jei-1.16.3-7.6.0.49.jar, AttributeFix-1.16.3-8.0.2.jar, spookarms-1.0.0.4.jar, EyesInTheDarkness-1.16.3-0.7.0.jar, Splashy-1.16.3-5.0.1.jar, immortuoscalyx-1.1.4.jar, Clumps-6.0.0.12.jar, FastWorkbench-1.16.3-4.4.0.jar, Controlling-7.0.0.9.jar, Placebo-1.16.3-4.3.3.jar, froglins-1.16.3-1.0.1.0.jar, LibX-1.16.3-1.0.2.jar, Bookshelf-1.16.3-8.7.20.jar, Tips-1.16.3-2.0.13.jar, Undercover Witches 1.0.1.jar, FastFurnace-1.16.3-4.3.0.jar, spooky-autumn-forests.jar, paranoia-1.16.3-1.0.0.1.jar, Toast-Control-1.16.3-4.3.0.jar, lorespawn-1.16.3-0.0.4.jar, mystical_pumpkins-0.1.4.jar, CorruptedLand-1.1d.jar, forge-1.16.3-34.1.35-universal.jar, PumpkinSpiceEverything-1.0.8.jar, OpenLoader-1.16.3-7.0.3.jar, quickspawns-1.16.2-1.0.1.jar, quickhomes-1.16.3-1.2.6.jar, spark-forge-1.16.3.jar, Morpheus-1.16.3-4.2.63.jar, travellers_map-1.16.2-0.6.4.jar
Loaded 10 recipes
Registered 0 additional loot tables.
Loaded 940 advancements
Registered 0 additional recipes.
Using new advancement loading for net.minecraft.advancements.PlayerAdvancements@62fac30f
Could not serialize net.minecraftforge.server.command.ModIdArgument@7b75f9a9 (class net.minecraftforge.server.command.ModIdArgument) - will not be sent to client!
Could not serialize net.minecraftforge.server.command.EnumArgument@76e320c9 (class net.minecraftforge.server.command.EnumArgument) - will not be sent to client!
Saving the game (this may take a moment!)
Saved the game
We only found out after a reload to change a config option in another mod that homes and spawn commands where all invalid nothing else was given error wise sadly...
Hmmm, does reload unregister commands? If so it's probably because it is only registered in setup. Is there an event for command registration?
I'm not sure after 1.12 myself, I've a PR waiting to be finished/commented on by Lukas for client side commands because after 1.12 is WAAAy out of my area sadly Prod him on Discord or I can link you to his PR for one of my mods if that might be of any use to you
Found this from sinkillerj/ProjectE#2128. The issue is that FMLServerStartingEvent is still being used to register commands instead of RegisterCommandsEvent. This means that when vanilla nukes the existing DataPackRegistry and creates a new instance your commands are not present as they aren't being registered again to the new DataPackRegistry
Yeah. I'd known about this. Thanks for letting me know though, in case I hadn't!
Don't really get around to updating this set of mods much. Most of the work is doing the actual release and not the fixes :3
Found this documentation on registering Forge events for v1.16.x