Capability Invalidation for Chests is broken on NeoForge

Question

Capability Invalidation for Chests is broken on NeoForge

shartte opened this issue 7 months ago · 5 comments

shartte commented 7 months ago

This overridden method breaks the NeoForge patch that triggers capability invalidation if a chest is changed from single to double (or back):

https://github.com/Reforged-Hub/radium-upstream/blob/develop/src/main/java/me/jellysquid/mods/lithium/mixin/util/inventory_change_listening/ChestBlockEntityMixin.java#L24

The @Intrinsic actually seemed correct, why is that commented out?

dima-dencep · Answer 1 · 2024-03-15T21:30:22.000Z

I don't remember very well, something to do with injections to interfaces

shartte · Answer 2 · 2024-03-15T21:37:08.000Z

Hm? setBlockState is on BlockEntity, that should not relate to interfaces

dima-dencep · Answer 3 · 2024-03-15T22:15:21.000Z

 Mixin apply failed lithium.mixins.json:util.inventory_change_listening.ChestBlockEntityMixin -> net.minecraft.block.entity.ChestBlockEntity: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException @Intrinsic method must be prefixed interface method, no rename encountered on setCachedState(Lnet/minecraft/block/BlockState;)V in lithium.mixins.json:util.inventory_change_listening.ChestBlockEntityMixin [ -> MAIN Applicator Phase -> lithium.mixins.json:util.inventory_change_listening.ChestBlockEntityMixin -> Apply Methods -> (Lnet/minecraft/block/BlockState;)V:setCachedState]

In fact, I just now saw that neoforge overrides this method.

shartte · Answer 4 · 2024-03-15T22:21:15.000Z

Can't you just allow it to fail the @Intrinsic then?

dima-dencep · Answer 5 · 2024-03-15T22:30:47.000Z

I think that's what you need

Share to