Railcraft Reborn

Railcraft Reborn

Mods
7M Downloads

[1.20.1] Interaction with GTCEu-Modern preventing glass bottle use

loving2 opened this issue ยท 2 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Description of the Bug

With just GTCEu-Modern installed, there is functionality to brew potions in a Brewery machine. This machine allows inserting potion fluid into the machine input by clicking potion bottles on the input. It also allows for potion extraction by clicking empty glass bottles on the output.

With railcraft also installed, the extraction of the potion from the output fails.

Railcraft Reborn version

1.1.8

NeoForge/Forge version

47.3.11

Minecraft version

1.20.1

Minecraft server

No

To Reproduce

  1. Install GTCEu-Modern v1.6.2 and Railcraft Reborn 1.1.8
  2. Place an Ultimate Brewery down
  3. Place a Creative Energy source down next to it
  4. Set the Creative Energy to UV and Active
  5. Insert 3 awkward potions into the Ultimate Brewery
  6. Insert a golden carrot into the Ultimate Brewery
  7. Use an empty glass bottle to try to extract the resulting Night Vision potion

Expected behavior

The empty glass bottle should become filled with the Night Vision potion.

Logs & Environment

No response

Screenshots & Video

No response

commented

I suspect this is due to the canFillFluidType call in CreosoteBottleWrapper but I'm not certain. I also spotted where you add a capability to the glass bottle.

commented

I have been able to fix the issue in my local testing by changing the return of canFillFluidType to always be true here. I can make a PR of this if you'd like, but I'm not sure what the ramifications are, if any, from doing this.