Different accepted MC versions in @Mod and mcmod.info

Question

Different accepted MC versions in @Mod and mcmod.info

NitroxydeX opened this issue 8 years ago · 5 comments

NitroxydeX commented 8 years ago

In @mod Minecraft 1.10.2 and 1.11 are defined to work with Railcraft while mcmod.info only references 1.10.2.

This causes a wrong MC-Version detection when Railcraft is inside an 1.11 environment. We noticed this during our workspace upgrade to 1.11.

https://github.com/CovertJaguar/Railcraft/blob/mc-1.10.2/src/main/java/mods/railcraft/common/core/Railcraft.java#L64

https://github.com/CovertJaguar/Railcraft/blob/mc-1.10.2/version/gradle.properties#L2

liach · Answer 1 · 2016-12-06T14:42:08.000Z

That is right. It means to exclude 1.11

NitroxydeX · Answer 2 · 2016-12-06T14:48:59.000Z

@liach But on the other side 1.11 is defined in the @mod method to work with Railcraft.

KnightMiner · Answer 3 · 2016-12-06T15:09:39.000Z

That is a mathematic domain in which 1.10.2 is included (square bracket) and 1.11 is excluded (round bracket). It's the same as saying 1.10.2 <= version < 1.11.

NitroxydeX · Answer 4 · 2016-12-06T15:16:14.000Z

Ah well because the comma is missing after 1.11. But you just could make the closing ] to only accept 1.10.2.

liach · Answer 5 · 2016-12-20T01:13:55.000Z

@NitroxydeX I now ported Railcraft to 1.11. Feel free to use it #1042 but do not distribute.

Share to