Railcraft

Railcraft

Mods
34M Downloads

Tank/Boiler GUI glitches: tanks and temperature scaling mismatchs.

alwaeles opened this issue · 14 comments

commented

Description of the Bug
In both tanks and boilers GUIs, the scale and the max of temperature, fluid amount, etc. are wrong.

To Reproduce
Steps to reproduce the behavior:

  1. Build a HP steam boiler,
  2. Make it heating,
  3. Look the steam, water and temperature levels...

Expected behavior
The tank displays when the boiler is realy full, and not less-than-half full...
The temperature display doesn't get overlapped over some other textures...

Screenshots & Video
https://axeland.re/2A3h7d9
https://axeland.re/2A0lDcm
Boiler Bug

Environment

  • Railcraft 12.0.0-alpha-9
  • Forge 14.23.5.2780
  • I don't thing it's a mod conflict...

Additional context
None

commented

err, this involves the one probe mod. please don't blame railcraft

commented

If it is caused only by One Probe Mod, why the boiler says full and nothing gets out with a pipe connected to the boiler? Maybe because it is not really full. It's only a GUI mistake, but when One Probe says it's half full, the steam magically goes out, even that the boiler GUI says it's full since a while...

commented

which is the same as your broken fluid transfer description.

commented

the other issue is #1551

commented

Best bet would be to disable one probe and see if the issue still exists

commented

Tested on a almost vanilla instance:

Mods installed:

  • Minecraft Forge 14.23.5.2780,
  • Railcraft 12.0.0-alpha-9
  • Buildcraft 7.99.19 (don't say this is the cause, it does the same with Thermal Dynamics)

Result:

Check it on YouTube

  • 👍1
commented
  1. Try in 1.7 and see if the tank auto pushes content to adjacent blocks like the pipe.
  2. Try with wooden fluid pipe and a redstone engine powering the pipe.

Please help me test these two and then I can identify the cause and make a proper fix for the issue.

commented

It should work on anything with a FluidHandler that accepts input. I don't know about pipes, but a BC Tank next to the tank of the Boiler should for sure be filled.

Railcraft/src/main/java/mods/railcraft/common/blocks/multi/TileBoiler.java

Lines 237 to 240 in d7af7f9

StandardTank tank = mBlock.tankManager.get(TANK_STEAM);
FluidStack steam = tank.getFluid();
if (steam != null && (mBlock.boiler.isCold() || steam.amount >= tank.getCapacity() / 2))
mBlock.tankManager.push(tileCache, getOutputFilter(), EnumFacing.VALUES, TANK_STEAM, TRANSFER_RATE);

commented

I added The One Probe and TOP Addons which displays the real content of the tanks then I waited a bit and I recorded...
This is the record

commented

I would guess that the most likely cause is a mismatch on tank capacity for the client and server.

  • 👍1
commented

Probably

commented

Will have a discussion on whether to send new capacity or to send multiblock formation events and compute on client.

commented

Finished in #1723 and #1730.

commented

Partially resolved in #1723, forgot to put boiler fix in.