Railcraft

Heyo

[05:07:29] [Client thread/ERROR] [railcraft]: Cannot initialize silk touch drops
[05:07:29] [Client thread/ERROR] [railcraft]: java.lang.NoSuchMethodException: net.minecraft.block.Block.getSilkTouchDrop(net.minecraft.block.state.IBlockState)
[05:07:29] [Client thread/ERROR] [railcraft]: java.lang.Class.getDeclaredMethod(Unknown Source)
[05:07:29] [Client thread/ERROR] [railcraft]: mods.railcraft.common.plugins.forge.HarvestPlugin.<clinit>(HarvestPlugin.java:53)
[05:07:29] [Client thread/ERROR] [railcraft]: mods.railcraft.common.items.ItemSteelAxe.initializeDefinition(ItemSteelAxe.java:41)

To Reproduce

Install forge-1.12.2-14.23.5.2796-universal
Install railcraft-12.0.0-alpha-9
Look in the logs

Environment

railcraft-12.0.0-alpha-9
forge-1.12.2-14.23.5.2796-universal

This thing is intended for tunnel bores to mine with silk touch enchantment. Should not impact your daily lives by too much in theory.

What is this stuff? I see references to #1314 #1323

Railcraft/src/main/java/mods/railcraft/common/plugins/forge/HarvestPlugin.java

Lines 49 to 62 in fbb2d6d

    
           static { 
        
               String methodName = Game.DEVELOPMENT_ENVIRONMENT ? "getSilkTouchDrop" : "func_180643_i"; 
        
               MethodHandle handle = null; 
        
               try { 
        
                   Method method = Block.class.getDeclaredMethod(methodName, IBlockState.class); 
        
                   boolean oldAccessible = method.isAccessible(); 
        
                   method.setAccessible(true); 
        
                   handle = MethodHandles.lookup().unreflect(method); 
        
                   method.setAccessible(oldAccessible); 
        
               } catch (Throwable throwable) { 
        
                   Game.logThrowable("Cannot initialize silk touch drops", throwable); 
        
               } 
        
               GET_SILK_TOUCH_DROP_METHOD = handle; 
        
           }

Couldn't you do this with an AT?

Hmm, is Game.DEVELOPMENT_ENVIRONMENT initialized incorrectly? This cannot be done with access transformers because this method is protected (overriding methods cannot be all transformed to be public).

I think it looks at the name of Entity.world. I don't know if its current.

You should use ReflectionHelper. It does most of this for you.

Also
https://github.com/MinecraftForge/MinecraftForge/blob/1.12.x/src/main/java/net/minecraftforge/fml/relauncher/FMLLaunchHandler.java#L138-L142

~~The reflection helper does not cache the method or method handle, making it inefficient.~~

The reflection helper is deprecated as well. Looking for Entity.world is fine because mods can only run under searge name (playing) or mcp name (dev env).

Ah spotted the fix. Should use Game.OBFUSCATED instead

Uh, made a fix on github.

The reflection helper is deprecated as well.

Says who?

Oh, because that class is loaded by another class loader which is not the launch classloader.

I see, it does however appear to have been properly replaced by ObfuscationReflectionHelper. As for the caching issue... do that yourself, you already are. Stop reinventing the wheel.

	static {
	String methodName = Game.DEVELOPMENT_ENVIRONMENT ? "getSilkTouchDrop" : "func_180643_i";
	MethodHandle handle = null;
	try {
	Method method = Block.class.getDeclaredMethod(methodName, IBlockState.class);
	boolean oldAccessible = method.isAccessible();
	method.setAccessible(true);
	handle = MethodHandles.lookup().unreflect(method);
	method.setAccessible(oldAccessible);
	} catch (Throwable throwable) {
	Game.logThrowable("Cannot initialize silk touch drops", throwable);
	}
	GET_SILK_TOUCH_DROP_METHOD = handle;
	}

Share to

Heyo

To Reproduce

Environment