Railcraft

Railcraft

34M Downloads

Tunnel bore doesn't use a "shovel" with BwM's HCPiles so only gets piles of dirt/gravel/sand

ElectroBot opened this issue ยท 10 comments

commented

Minecraft: 1.12.2
Forge: 14.2.5.2815
Railcraft: 12.0.0-beta-5
Better with Mods: 1.12-2.3.20-1027 @primetoxinz
Better with Lib: 1.12-1.5

Description of the Bug
When using a Railcraft Tunnel Bore with Better with Mods installed (with HCPiles turned on Makes soils drop 75% of their content if not broken with a shovel to incentivize the use of shovels) the tunnel bore gets piles of dirt/sand/gravel instead of the actual block.

To Reproduce
Run Tunnel Bore with BwM installed with HCPiles turned on (default) and mine through dirt/grass/sand/gravel

Expected behavior
Tunnel Bore should mine with a "shovel" to get full block. Not sure which mod (Railcraft of Better with Mods) should fix this

Screenshots & Video
2019-03-04_20 12 55

Logs & Environment
latest.log --> https://paste.dimdev.org/agemopewuw.md

  • Full log:
  • Crash report (If available):

Additional context
EDIT primetoxinz is on an indefinitive break from MC dev

commented

Hmm, so use fakeplayer here instead

WorldPlugin.playerRemoveBlock(world, searchPos.toImmutable(), CartTools.getCartOwnerEntity(this),

commented

This one I can fix, but for the glass bottle compatibility I can't. Seems people don't even care about glass bottles...

commented

Glass bottles?

commented

@CovertJaguar when some other mods like charset or cuisine is installed with railcraft, glass bottles can no longer extract creosote. ask @3TUSK as he has tested and confirmed.

commented

I was summoned.

Long story for short, as one of main Cuisine (https://github.com/Snownee/Cuisine) dev, I received a report claiming that vanilla glass bottle failed to take juices from Cuisine out under a certain circumstance. After in-depth investigation, it turns out that such situation will occur if multiple mods attach CapabilityFluidHandler.FLUID_HANDLER_ITEM_CAPABILITY to the same item, causing overlap between all mods doing so. That said, one can only get one version of IFluidHandlerItem, and which one will be returned is undefined.
Honestly speaking, I do not have a solution, either.

commented

Can say the same for GregTech CE (https://github.com/GregTechCE/GregTech). I'm attaching CapabilityFluidHandler.FLUID_HANDLER_ITEM_CAPABILITY) to glass bottles too, to allow filling them with potion fluids, and it'll conflict with all other mods doing similar things.
In my opinion, such kind of issues is system design flaw and should be solved by forge.

commented

I guess it can be temporary solved by delegating to previously attached IFluidHandlerItem instance every time some mod provides one. Since AttachCapabilitiesEvent keeps capabilities in LinkedHashMap, order is predictable and it should work as long as all attaching mods do such thing.

commented

I wonder if this is why I was getting a pink "Uncraftable potion" when grabbing water from a Cooking for blockheads (inf water) sink with vanilla glass bottles, but was able to get reg water when using in-world water.

commented

Should move the glass bottle thing to a new issue.

commented

@ElectroBot, most likely yes, judging from your description and the actual code of Cooking For Blockheads.

Also, another possible solution is to provide a config option to disable "attaching IFluidHandlerItem to vanilla glass bottle, for example EnderCore has added such an option. It might not be a choice if there is a design choice, though...