Thaumcraft 4.2.x and Railcraft incompatibility crashes.
Azanor opened this issue ยท 12 comments
I've had the following crashes reported to me when a user opens the thaumonomicon while having RC installed. This is in the current Thaumcraft 4.2.x beta versions for MC 1.7.10.
Would it be possible to add the ThaumCraft API as a compile-time dependency in your gradle build file? You seem to have done something similar for BuildCraft, and the ThaumCraft API is available as as separate repo on Github, which makes me think it's doable. This way you would have it available during development, but not automatically bundle it with your jar file.
Though I must admit I'm not entirely sure what would happen if a modpack is loaded that has RailCraft but not ThaumCraft. I'm not an expert on classloaders and such.
Though I must admit I'm not entirely sure what would happen if a modpack is loaded that has RailCraft but not ThaumCraft. I'm not an expert on classloaders and such.
Good chance it would explode, but I'm not actually sure.
Turns out adding ThaumCraft as compile time dependency is not as easy as it seems (or maybe I'm overlooking something, maybe Azanor can point us in the right direction?), so I'll simply add the updated API classes to RailCraft, fix whatever gets knocked over, and submit a pull request (assuming I can get it to work)
I just confirmed it is the shipped API. Removing it from the RC jar makes everything work as it should.
Oh and a possibly related issue: I notice you include a copy of my API in your mod. This could cause problems, especially if the API is outdated. I'm not sure if it is related to the above issue, but it is possible,
Your documentation is a little sparse, is that the recommended usage of the api?
Yeah, usually it isn't a good idea to ship API's in your code. With the 4.2 update I had to fix a major bug with crucible crafting which affected the API.
If RC just happens to be loaded before TC (which it usually will be) then your version of the API overwrites mine and crashes occur.
I'd ask Greg. He's interfaced, API-free, with more mods than any other mod I know of, except maybe buildcraft.
Yeah, except for the part that I'm not really sure how to adapt my code to function without the files there. Its not quite as simple as slapping @optional everywhere and hoping it works.
Seems to be no more reports. Close @CovertJaguar ?