Railcraft

Railcraft

34M Downloads

Could not find property 'version_major' on root project 'Railcraft'.

EoD opened this issue ยท 5 comments

commented

Thanks for uploading the code, but I think you missed some properties file like a "gradle.properties"?

On a gradlew setupDecompWorkspace --refresh-dependencies:

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/Railcraft/build.gradle' line: 20

* What went wrong:
A problem occurred evaluating root project 'Railcraft'.
> Could not find property 'version_major' on root project 'Railcraft'.

The list of variables which seem missing (you might need to adjust the values):

version_major = 9
version_series = 3
version_revision = 2
version_build = 0
mcversion = 1.7.10
forgeversion = 10.13.0.1207
mcUsername = Steve
mcPassword = ILoveNotch
forgeMavenUsername = none
forgeMavenPassword = none

Although I don't understand why you have a mcUsername and mcPassword entry. Forge-Gradle should automatically be able to run a test environment (gradlew runClient) without a username and password.

commented

The repo readme explains this. Though it looks like I missed the Railcraft version info.

Some of these should probably be separated into a file that can be committed to the repo, but this works for the moment.

As for why do you log in, its because its a real pain having your inventory and position reset on every restart when you don't.

commented

The problem with adding gradle.properties is that it makes it too easy to accidentally commit your login information.

And the maven stuff is broken. I could never get it to work. I'm the only person who needs that anyway. If the buildscript is requiring that...that's a bug.

commented

Oh, I see. Thanks for adding those entries, but I think you missed the forgeMaven....

Do you mind me adding a gradle.properties to your repo? Or does it conflict with your local setup?

commented

@CovertJaguar you could also remove the login info from the gradle stuff and put it intro your launch parameters inside your idea

commented
$ ./gradlew setupDecompWorkspace --refresh-dependencies
****************************
 Powered By MCP:             
 http://mcp.ocean-labs.de/   
 Searge, ProfMobius, Fesh0r, 
 R4wk, ZeuX, IngisKahn, bspkrs
 MCP Data version : unknown
****************************

FAILURE: Build failed with an exception.

* Where:
Build file 'Railcraft/build.gradle' line: 286

* What went wrong:
A problem occurred evaluating root project 'Railcraft'.
> No such property: forgeMavenUsername for class: org.gradle.api.publication.maven.internal.ant.DefaultGroovyMavenDeployer

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Where is the bug there? You are just missing the two variables.

If you are worried about someone submitting his/her password you could also put those variables in an external properties file and add the file to .gitignore. I can rewrite your build.gradle script such that it will also work if any of the usernames is missing.