Railcraft

Railcraft

34M Downloads

Recipes that use glass do not accept oredict glass entires

skyboy opened this issue ยท 7 comments

commented

We have blockGlassColorless for unstained glass blocks and blockGlass for any glass block, as well as the various individual colors. Entries mirrored for panes in the same format: paneGlass

commented

At a glance it appears to be "all of them." Give me a moment to make a list and I will edit.

Affected recipes:
Tank Gauges
Engines
Strengthened Glass
Fluid Loader/Unloader
Magnifying Glass
Trackman's Goggles
Signal Block Surveyor
Signal Lamps
Electric Meter

Unaffected recipes:
Trade Station

commented

The magnifying glass does use oredict entries, for instance. Note that the items only use *Glass when it makes sense and *GlassColorless when it's meant to be a clear pane.

commented

Then it would appear few mods actually use the colorless oredict. That's irritating.

So a few recipes would continue to not accept incorrectly categorized other mod items, but things such as engines, the fluid (un)loaders, and the surveyor should not require colorless glass; where the gauges and strengthened glass are more debatable.

commented

I think colorless glass should be used anywhere a clear pane is necessary for visuals. And that's usually the case.

commented

Which recipes are you talking about, specifically? I should have moved over most recipes to use appropriate OreDict entries.

commented

I am pretty sure I replaced every instance of Blocks.glass and Blocks.glass_pane in that commit.

commented

So is this invalid?