Railcraft

Railcraft

34M Downloads

Too Many Detectors

CovertJaguar opened this issue ยท 14 comments

commented

While it doesn't really matter codewise too much, I do however feel some of the Detector variants are redundant.

Specifically I was thinking of the follow changes:

  • Remove Explosive Detector (Advanced Detector can do the same thing)
  • Remove Energy Detector (again Advanced Detector, RF loaders already use Advanced Detector in recipe, IC2 Loaders could as well)
  • Remove Powered Detector (does anyone use this?)
  • Combine Animal and Mob Detector (they already share near identical code, and a new GUI is on the way)

For anything else anyone might want, IC2/RF power levels etc, it's generally a lot simpler for me to just add a new Routing Table condition.

Does anyone else have any thoughts?

commented

There's a suggestion.
It may be a good idea to combine all detectors into one, this one detector has about 2 to 3 features and you can select in gui. And by adding upgrade items (just like adding upgrades to ic2 machines) you can add more features that can select in gui.

commented

That would make it a lot harder for addons to add custom detectors.

commented

Just asking here (i could provide some code to help, Because its not bound to the Json System):
Why dont you compress the Detectors to types: Energy, Entity, Item, Fluids, Etc...
(I did actually use the EnergyDetector on the PlayServer with a friend (WithIC2C))
And have SubTypes of these Detectors. Because you can have as much blockstates as you want just the Metadata is limited to 16 (if you expand on some parts)
Is that a valid option?
It would open the room for more Detectors.

commented

I'd actually prefer fewer Detectors. Easier on new players. Everything the Energy Detector can do, the Advanced Detector can do just as easily.

commented

hmmm ok what about splitting? (I think all detectors should remain because all of them have their use)
And making another modul for them...

commented

Most of the ones I want to remove were created before the Advanced Detector existed. It completely overlaps their functionality 100%. I'm not sure "useful" is the correct term.

commented

I have suggestion combine all the detecters into a generic block. When right clicked it will bring up a gui and you can select the modes of operation.

commented

Or make Plugs that you can put on the Detector. With that you can have up to 6 Detectors in 1 Block (and you can decide which output they use (a redstone output plug))

commented

@Joshwoo70 That makes little sense.

@CovertJaguar I think your suggestions are good.

commented

Just fyi, anyone asking for a super generic configurable Detector should learn how to use the Routing Detector, because it can do most of that stuff already (and logic!). ;)

commented

true... But you need to know the language :3

commented

This would be a good opportunity to rename them to "cart detectors". People
often misunderstand their purpose.

commented

@Speiger for that one can use my routing table editor application cough cough

commented

@Forecaster never said its a hard language but its still a custom language (good documented) but i know people who stop at the easiest stuff when they instantly do not understand it... (Also a tool like that xDD, I wish that i had a tool that converts Lua to Java & back so i could use OpenComputers & CC)