Rain Be Gone Ritual (Fabric)

Rain Be Gone Ritual (Fabric)

229k Downloads

Configurable delay for Advancement Screenshot

James103 opened this issue ยท 2 comments

commented

Information

Mod name: Advancement Screenshot

Feature description

The cooldown value in the following code should be configurable. This should allow the mod to be compatible with Advancement Plaques or other mods that make the client take more than 20 ticks (1 second) to fully show the advancement on screen.
https://github.com/ricksouth/serilum-mc-mods/blob/1cf87f06e08dd6904fd420256c01d65006fcac31/sources/Advancement%20Screenshot/src/main/java/com/natamus/advancementscreenshot/util/Util.java#L21-L24

Ideally, this should be configurable per advancement tier (Task, Goal, Challenge) since Advancement Plaques has the same per-tier configuration for the fade-in, fade-out, and total time.

commented

I appreciate the feature suggestion! In order to reduce the amount of open issues on this Github repository, I've created a separate Github project page for all mod feature requests. It can be found here:
https://serilum.com/mods/requests.

I'll be closing this issue, but I'm keeping track of all ideas on the project page over there.

It definitely does not mean I am not interested, and I will post a comment here as well if/when a feature is implemented.

Thank you very much for the suggestion!

commented

Hey!

I still appreciate the submission a lot, and wanted to give an update on this. While I'd love to add all features submitted on the issue-tracker, due to having limited time, I've just not been able to. In order to see which features users would like to see most, I've updated https://serilum.com/mods/requests. The page now shows a table, with all feature request submitted.

Users are able to upvote requests by reacting to the first issue post here on GitHub with one of the ๐Ÿ‘ ๐Ÿ˜€ ๐ŸŽ‰ โค๏ธ ๐Ÿš€ ๐Ÿ‘€ emoji's. The request with the most unique reactions, will be shown at the top.

This doesn't necessary mean I'll only work on popular features in the upcoming years, but it does help with prioritizing.

Thank you again for the suggestion!