[NeoForge 1.21.1] Extreme framerate lag with Excavated Variants and Dynamic Asset Generator
Closed this issue · 3 comments
When opening the config screen for Raised, there is extreme framerate lag with both Excavated Variants and Dynamic Asset Generator
However, with Excavated Variants disabled but Dynamic Asset Generator enabled, the framerate issue is gone
I am unsure if this issue should go here or to the Excavated Variants Github issue page
Running NeoForge on 1.21.1, NeoForge version 21.1.200, and here is the latest log
It seems this comes down to when Raised is checking the loaded packs for the layer icon asset which may not exist. I suppose Dynamic Asset Generator is creating a boatload of virtual packs for Excavated Variants, and having to search through them all it drags down my 7950x to 1 fps. I suppose caching the resource locations of all the layers would mitigate this conflict.
Doing some testing, moving the pack check into the layer list entry's constructor does still chunk it out at first when you first open the screen, but after that it does resume normal performance. This is a better approach than doing it every frame render anyways.
https://github.com/yurisuika/Raised/actions/runs/17029406161
So for now that is a quick improvement, but I want to look into moving the pack check deeper into the pipeline when it loads the packs to make a release.