Random Things

Random Things

Mods
44M Downloads

Hacky Bottle of Air Reflection

Yslohr opened this issue ยท 0 comments

commented

Random-Things/src/main/java/lumien/randomthings/item/ItemBottleOfAir.java

Lines 19 to 36 in 27c32df

static Field inUseField = null;
static
{
try
{
inUseField = EntityLivingBase.class.getDeclaredField(MCPNames.field("field_184628_bn"));
}
catch (NoSuchFieldException e)
{
e.printStackTrace();
}
catch (SecurityException e)
{
e.printStackTrace();
}
inUseField.setAccessible(true);
}

This section seems extremely hacky. It has been making the already unstable forge development environment more unstable when you use random things as a dependency. These names should be provided by the Forge API (FMLDeobfuscatingRemapper etc...)
Keep in mind, this is with the VM argument "-Dfml.coreMods.load=lumien.randomthings.asm.LoadingPlugin" while having my mcp mappings (stable_39) in a folder called "mcp" at the root of the mod project. Forge version is 14.23.5.2854 for Minecraft 1.12.2 and using ForgeGradle 3.+