Rats

Rats

Mods
14M Downloads

Feature Order Cycle crash with Ratlantis and RFTools

Apollounknowndev opened this issue ยท 1 comments

commented

When RFTools creates a dimension with the Ratlantis biome and another biome, the game crashes due to a feature order cycle.

The source of this is in the ordering of features in the vegetal_decoration step here:

[
      "rats:ratglove_flowers",
      "rats:marble_pile",
      "minecraft:trees_jungle",
      "minecraft:bamboo_light",
      "minecraft:flower_warm",
      "minecraft:patch_large_fern",
      "minecraft:patch_grass_jungle",
      "minecraft:patch_sugar_cane",
      "minecraft:patch_melon",
      "minecraft:vines",
      "minecraft:brown_mushroom_normal",
      "minecraft:red_mushroom_normal",
      "minecraft:warm_ocean_vegetation",
      "minecraft:seagrass_warm",
      "minecraft:sea_pickle"
]

minecraft:bamboo_light being after minecraft:trees_jungle is inconsistent with both vanilla and modded jungles, and immediately leads to a crash.

minecraft:brown_mushroom_normal and minecraft:red_mushroom_normal being after minecraft:patch_sugar_cane, minecraft:patch_melon, and minecraft:vines is also inconsistent with vanilla and modded biomes, leading to basically any biome in combination with Ratlantis causing a crash.

To fix this, the features in this list should be reordered to this:

[
      "rats:ratglove_flowers",
      "rats:marble_pile",
      "minecraft:patch_large_fern",
      "minecraft:bamboo_light",
      "minecraft:trees_jungle",
      "minecraft:flower_warm",
      "minecraft:patch_grass_jungle",
      "minecraft:brown_mushroom_normal",
      "minecraft:red_mushroom_normal",
      "minecraft:patch_sugar_cane",
      "minecraft:vines",
      "minecraft:patch_melon",
      "minecraft:warm_ocean_vegetation",
      "minecraft:seagrass_warm",
      "minecraft:sea_pickle"
]
commented

Missed a second location of crashing. Here's the underground_ores step features in Ratlantis:

    [
      "minecraft:ore_dirt",
      "minecraft:ore_gravel",
      "minecraft:ore_andesite_upper",
      "minecraft:ore_diorite_upper",
      "minecraft:ore_granite_upper",
      "minecraft:ore_coal_upper",
      "minecraft:ore_iron_middle",
      "minecraft:ore_gold_lower",
      "minecraft:ore_redstone",
      "minecraft:ore_diamond_large",
      "minecraft:ore_lapis",
      "minecraft:disk_sand",
      "minecraft:disk_clay",
      "minecraft:disk_gravel",
      "rats:cheese_ore",
      "rats:ratlantean_gem_ore",
      "rats:oratchalcum_ore"
  ],

the upper granite/diorite/andesite features are in the reverse order they should be in, this also needs to be fixed.