Realistic Ore Veins

Realistic Ore Veins

356k Downloads

OreDict Support

NielsPilgaard opened this issue ยท 6 comments

commented

Hello!

I'd like to request the ability to specify a Block Entry as an oredict. I imagine it would work like so, based on the README examples:

"ore": "ore:oreIron"

and

{
  "ore": [
   {
      "block": "ore:oreIron",
      "weight": 4
    },
    {
      "block": "ore:oreCoal",
      "weight": 39
    },
    {
      "block": "ore:oreDiamond"
    }
  ]
}

I believe this can be achieved by getting the first entry of the oredict supplied.
The reason that I'd like this, is because I've created a ton of ores with ContentTweaker, and their internal names can fairly easily change, so it'd be nice to be able to reference them via oredict key.

I hope you'll consider it :)

commented

So I think that is doable, but there are a couple potential problems:

  • If there are multiple entries, the "first" one may not be consistent
  • It may be difficult to get the ore from an ore dictionary reference - Ore dictionary stores ItemStacks which don't map injectively onto IBlockStates
    That said, I'll give it a try.
commented

I think the consistency issue is up to the individual pack dev to solve, and can't really be avoided with this implementation (I think)
I think I know some mods that convert IItemStack into IBlockState, would you like links for reference? :)

commented

I know it's possible / how to do it, its just not reliable. (i.e. if you specify ingotIron, that block doesn't exist)

commented

Should be added in 2.0.10. If not open another issue and I'll look into it.
I also saw that you were needing indicators for your project - I wanted to mention that this mod can do indicators for its veins as well, and it supports weighted indicators. :)

commented

Damn that was fast, thank you!

Thanks, but I already implemented indicators with the mod Worldgen Indicators :)

commented

The oredict support works just as I had hoped, thanks again :D