Affected Mod Versions:

• Forge version: 12.18.2.2107
• RTG version: 4.1.1.2

Issue Description:

RTG Oak Trees will replace Blocks while growing, possibly other trees too.

Steps to reproduce the issue: (If it's easily reproducible.)

1. Go to Extreme Hills
2. Plant an Oak Sapling
3. Place some blocks around the Sapling, maybe some above
4. Use Bonemeal / Tourcherino / Wait a few minutes and hope you get an RTG Tree

I can confirm that this is definitely an issue with almost every single RTG tree.

Most trees do air checking for the leaves, but none check for air blocks when placing the logs.

My initial thinking is that logs should only check for air blocks when the tree is being generated from a sapling to reduce the extra overhead from world generation.

Fixed for 1.10.2 in 098d591

Was just coming to report this due to it breaking the Botania tree farm I was trying to set up in a Plains biome. Good to a fix is already in the pipeline.

@The-Arcanian This is fixed in the 4.1.1.5 version for 1.10.2... are you on a different MC version?

Well that's a problem.

I am using RTG-1.10.2-4.1.1.5 and it replaces the blocks I place above the sapping if it is growing a Large Oak Tree in a Plains biome, but there has to be room for a Small Oak Tree to grow. I have not tested any other cases other then that it is at least partially biome specific, because it did not happen when I accidentally tried testing it in a Sunflower Plains.

Also before testing this in creative I tried to use Birch in my play word and was getting Large Birch Trees with the same block replace effect. Did you guys add those?

@The-Arcanian We've added some block-checking above the sapling (Y-axis only) before the tree tries to generate. If there's nothing in the way, up to the height of the tree, it will generate. If it finds any non-air block along the way, it won't.

This isn't an ideal solution, but hopefully it will give you some options when designing your tree farms.

Also, for reference, be sure to remember the following (some might be obvious, but including to be thorough):

1. "RTG trees" are different than "vanilla trees"
2. Saplings can only grow into an RTG tree if the biome naturally generates a tree that drops the sapling that is placed. For example, if you place a spruce sapling in a Plains biome, no RTG trees will generate because the only RTG trees that naturally generate in Plains are the large Oak (which drops an oak sapling) and the large Birch (which drops a birch sapling). Unfortunately, there isn't a master list of all the RTG trees and the biomes in which they generate, but we'll try to get something put together in the future.
3. When an RTG tree grows from a sapling, it doesn't replace any blocks that it's not allowed to... but sometimes it will grow around the blocks, making it look like it replaced them.
4. If RTG trees still aren't behaving as you'd like them to, you can disable them in the configs by setting B:"Enable RTG Saplings"=false

The new block-checking functionality will be in version 4.1.1.6 when it's released later today. Let me know how it works out for you.

Ok, it is fixed now it seams. To try and state more clearly; the problem was when trying to grow Oak or Birch in a Plains biome there appeared to only be a Y check up to the what was required for RTG's equivalent to Vanilla's Small Trees, therefor no tree would grow if there was a block low enough. But if there were no blocks to prevent a small tree, then the RTG equivalent to a Vanilla Big Tree would often grow, replacing any blocks where it wanted to place a wood block (leaves did not replace).

But like I said 4.1.1.6 seams to have fixed it, I am no longer getting what looks like Vanilla Large Trees growing through the blocks that I place above the saplings.

Is it fixed in 1.7?

Not yet - we're hoping to release an update for 1.7.10 on Sunday - if we do, this will get fixed as part of the update.

Perfect, thanks. Further isolation testing shows that it's Recurrent Complex' trees.

Not sure if this is the right place... I've found that trees created during worldgen don't make these checks and are placed after villages are placed. The result being village houses with wood and leaf blocks where there should be stone and other materials.

Running rtg 1.10.2-4.1.1.8

Cheers!

@xenoflot

Not sure if this is the right place

No, this is a different issue, and @whichonespink44 added checks in RTG a long time ago to prevent what you are describing, atleast with respect to RTG generated trees. If you are seeing trees growing into village structures, then they are likely non-RTG tree and it is coming from the vanilla biome decorator, or another mod's biome decorator.

If you still feel that it is RTG's trees generating in/on village structures, please open a new issue.

Fixed for 1.8.9 in 385020f

Fixed for 1.7.10 in 7e6daf9