Game Crashing when generating terrain with COFH present and loaded
samiscool51 opened this issue · 7 comments
Affected Mod Versions:
(Please list other mods and their versions if you feel they are relevant to this issue. i.e. Biomes O' Plenty)
- Forge version: 12.18.3.2316
- RTG version: 1.10.2-4.2.0.0-snapshot-4
- COFH version: 1.10.2-4.1.9.13
Issue Description:
Whenever i load or create a chunk within a RTG enabled world with cofh enabled the game crashes
@KingLemming has been notified about this issue and i said to him that i would get your opinion about the crash log to see if something is wrong with RTG or COFH,
Steps to reproduce the issue: (If it's easily reproducible.)
- download COFH 1.10.2-4.1.9.13
- load up a new world (or an old one) and generate or load chunks
- wait for the game to crash, i have noticed it sometimes doesn't crash when generating or loading new chunks making it annoying to recreate
Extra Information:
Crash log - https://pastebin.com/j32Xbeea
mod list - https://pastebin.com/ctXvDbDg
I've narrowed down the offending mods to the combination of CoFHCore 4.1.9.13, RTG (either snapshot or 4.1.2.4 -- I tested with 4.1.2.4), and Pam's HarvestCraft 1.10.2j. All three mods must be present for the crash to occur.
Issue has been reported to the other two repositories:
https://github.com/CoFH/Feedback/issues/340
MatrexsVigil/harvestcraft#310
Feel free to close this out. I've put defensive code in CoFHCore which will mitigate the underlying crash. For reference, it seems that there are certain conditions where the Post event manages to resolve before the Pre event.
So this may even be some bug with Forge and the event bus. In any case, there's no actual harm with me just putting in a null check. I apologize for my grumpiness in my own thread and for making assumptions about RTG's code.
It's all good, glad we got to the bottom of it.
Gonna see if there's anything RTG can do to optimize its terrain generation, since you mentioned in the other issue that it seemed to happen when large mountains were generating. Maybe @Zeno410 has some thoughts on how that might be possible?
@samiscool51 @ElvenChaos @ACGaming
I believe this version of CoFH Core resolves this issue: https://minecraft.curseforge.com/projects/cofhcore/files/2446771
Can you guys confirm?
