ChunkGeneratorRealistic.java need fix
Ezoteric opened this issue · 14 comments
Line 790 orso ->>> worldObj.setBlock(sn1 + x, sn3, sn2 + y, Blocks.snow_layer, 0, 2);
I turned off this line and it doesnt spawn those snow layers in warm biomes and on trees but also no snow on snow biomes, there was no snow anywhere. So if you can tell it to ask if the biome is cold enough to place it then it wont spawn in warm biomes and on trees anymore :) i think 🌴 ;)
If easy, try add it to 0.0.6 plz if taking to long then its sad :P
Haha, nice one -only just got back from dinner. Real life is over now... time to mod some Minecraft!! :)
Oh, and feel free to close this issue if you've fixed it - if not, let me know and I'll look into it.
If oceans are off they wont create btw.
Ill keep rivers off for my testing and prolly wont ever set it on when playing when ever we get to that point :P
Ok, I'm looking at this now. Do you still want me to do what you asked in the original post above? If so, I'll start looking into it.
Yes, I have no idea how to add it. So if you can make sure it only generates in snow biomes I think the ugly snow patches are gone from trees and warmer biomes
Ok, I've added a possible fix in 350703a.
I've tested in Cold Beaches, and there was snow. And I've tested in Beaches, and there was no snow. But I haven't tested in a normal world yet, so the rivers might still cause problems. I'll do some more testing in about an hour.
I just finished generating a map, and yes this is the fix BUT as i expected the biome bleeding also stopped, but this is prolly also cause the biomes it bleeds into is never cold but always hot or wet.
So when you have fixed the biomes transitions i think you need to change the temp to max cold so it still bleeds into cold but not in temp hot or warm (if your making them by snow cold temp hot wet) :P
Check it out, i also used big trees mod as on all those big trees where snow layers as well (was also a complaint of some ppl)
Also tested if the non paint worked for volcano's and shit but that wasnt a succes as you can see, a clean tropical island and a bit next to it you see a volcano on the wrong place and again chopped up.
south west corner ;)
Euh... this was a question for you :P
i dont know how to do that haha
In the meantime... i turned off vanilla rivers in config and look what i get.
They all are oceans now, cept for the icy ones and the big lake at the south map border next to the snow biome. besides that all are oceans and there are still rivers :P but as you see no more fake empty beach that was a river :P
Interesting... looks like turning it off in the config just stops the vanilla River biome from generating as a biome, but it's still using them as transitional biomes? Hmmm. I wonder what would happen if you disabled oceans as well. Probably the same thing.
dunno but when rivers was on there was hardly any ocean in many maps so i tested it :P
So the problem was having it as biome the whole time, maybe we need to do the same with beaches :P then we dont have those beach biomes but small transitions :D
ill check what happens when i turn off oceans :P