Realistic Terrain Generation

Realistic Terrain Generation

3M Downloads

BOP sub-biomes generate, even if disabled in RTG configs

scalda opened this issue ยท 30 comments

commented

Hi all, i am running rtg latest version of the mod in a dev pack for iskall85 and villages aren't spawning in the BOP biomes. is there anychance this can and/or will be implemented?

regards

Scalda

commented

Ok, we will keep looking i'm wondering if they aren't spawning as much as our terrain is quite hilly from rtg

commented

RTG's current bias towards hilly/mountainous terrain is probably the biggest factor at play here. I was going to wait until Beta before addressing that issue, but I might see if I can do something before then. I'll close this for now, but feel free to re-open if you still don't find any.

commented

what is your village weighting in you BOP config?

commented

Standard at my setup cause the villages are often too big as it is :p

commented

"Distance between villages" = 32

But here's the interesting part...

Bayou=false

The screenshot I posted above was in a Bayou... so it looks like RTG ignores the BOP biome flags for village generation.

commented

hmmz thats weird yes.

commented

I wonder if the other village settings have any effect... I know the ones in EB do... when I had EB installed, I changed the distance to 8 and the size to 6, and massive villages were absolutely everywhere.

commented

Hmmz I haven't tested the latest version but I always had villages there :o

commented

Strange we can't seem to get any to spawn in a bop biome but found one in a
magical forest from thaumcraft
On 17 Oct 2015 4:54 pm, "Jason" [email protected] wrote:

Hmmz I haven't tested the latest version but I always had villages there :o

โ€”
Reply to this email directly or view it on GitHub
#225 (comment)
.

commented

Villages should be capable of generating in BOP biomes. I'll do a quick test to see if I can spot one.

commented

image

Seems to be working alright. I haven't checked every biome, but they should be able to generate in any BOP biome they would normally be able to.

Let me know how you get on.

commented

actually i'm in the same boat with the biomes spawning when they are disabled, as i have mangrove disabled yet still spawns in world.

Edit: just found i had mangrove enabled in BOP config folder but disabled in rtg config. hope that helps

commented

Yeah, just to clarify... RTG's configs intentionally override other mods' configs for biome generation. For example, if you set Bayou=false in BOP's "overworld biomes to generate" section, but you set generateBOPbayou=true in RTG's config, the Bayou biome will generate. So RTG controls biome generation, regardless of what you set in BOP's (or any other mod's) configs.

However... I was under the impression that RTG respected other mods' village config settings. It respects the village settings in EB, as mentioned above - but it doesn't seem to be respecting BOP's village config settings. And I'm not sure why. I'll have to look into this one further.

commented

yeah i see but i had it round the other way to what you have said, and was still getting the mangrove biome i have now disabled in both with the weights turned of and still had it generate.

commented

I think I may have fixed this issue. Here's a snapshot of 0.0.13 if anyone wants to test it out: https://goo.gl/nLQlLi

commented

ok thanks will check it out and let you know

commented

thats great villages seem to be spawning now i have found a couple. the next thing is i'm still getting mangrove biome spawn even thou it is disabled in both rtg and BOP

commented

Download source and remove it ;)

commented

@scalda I'll take another look at this tonight. Something odd is definitely going on.

commented

ok thank you, i thought it might be ids but i can't find anything conflicting in my config files

commented

Speaking of config files, would you be able to zip up your RTG config folder and attach it to this issue? It's probably fine, but I'd just like to rule it out for definite.

commented
commented

Not yet, sorry. I just need to finish a handful more biomes for the 0.0.13 release and then I'll be on with bug squashing.

commented

Did you manage to look at my config files?

commented

Ok, I've figured out what's causing this... basically, the only biomes that are generating when disabled are BOP's sub-biomes and ocean biomes - and the reason they're generating even when disabled is because their 'parent' biome is enabled.

For example, the Quagmire is a sub-biome of the Sludgepit biome, so... the only way to disable the Quagmire would be to also disable the Sludgepit. And if you disable the Sludgepit, the Quagmire biome won't generate even if it's enabled.

So...

I'm not quite sure what the best approach is here... I could either:

a) Remove all BOP sub-biomes from RTG (this would also get rid of ocean sub-biomes as well)

or...

b) Add comments to the config files explaining how sub-biomes work. So the options in the ConfigBOP.cfg file would look something like this:

[Sludgepit, Quagmire, Silkglades]
enableSludgepitBiomes=true'

I think I'm probably going to go with option B, unless someone can think of a better solution.

Let me know what you guys think.

commented

ok so that will explain why i was getting mangrove as it's a ocean sub biome, can't you have your config similar to how BOP have there's as you can disable each biome individually?

commented

It was the only one that I noticed to be spawning that was disabled
On 23 Oct 2015 11:18 pm, "WhichOnesPink" [email protected] wrote:

@scalda https://github.com/scalda - can you just confirm that it was
only the Mangrove biome that was generating even though it was disabled?
Because that's the only biome that had the typo, and that was the only
biome that I was able to reproduce the bug for.

โ€”
Reply to this email directly or view it on GitHub
#225 (comment)
.

commented

๐Ÿ‘

commented

Ignore everything that I said in my previous post.. it doesn't work like that at all (sounded good though! ๐Ÿ˜› )

The reason they're being generated even though they're disabled is because of a simple typo in the RTG code. I'm fixing it now and it will be part of the 0.0.13 release.

(Sorry for putting you through all this trouble)

commented

@scalda - can you just confirm that it was only the Mangrove biome that was generating even though it was disabled? Because that's the only biome that had the typo, and that was the only biome that I was able to reproduce the bug for.