Realistic Terrain Generation

Realistic Terrain Generation

3M Downloads

crash with BOP 2.1.0.1465

sircrimer opened this issue ยท 11 comments

commented

@sircrimer Do you happen to remember which biome you were in when it crashed? Are you able to log back into the world?

I've tried reproducing this with BOP 2.1.0.1465, but village generation seems to be working fine.

commented

Actually... I just noticed that you're using Forge 10.13.4.1558... can you try using 10.13.4.1448 and let me know if it still crashes?

commented

I suppose I could try to throw an exception if the 'Realistic' world type isn't chosen, similar to the way the game notifies you if you're missing a required mod.

I'd rather not have RTG just 'do nothing' if the Realistic world type isn't chosen though... that's kinda like asking Thaumcraft 'do nothing' if it's installed. If you want Thaumcraft to do nothing, then you remove Thaumcraft... same should apply for RTG - if you're not going to choose the Realistic world type, then remove RTG.

commented

Hmm, what if someone who plays with RTG world type on main world, want to test something with BoP world type on different world? Seems reasonable enough. But if this really hard to fix, well at least RTG should avoid crashes.

commented

Fair enough - I'll see what I can do.. hopefully it's just a case of checking the world type during preInit() and preventing any other code from executing if the Realistic world type hasn't been chosen.

commented

@whichonespink44 can confirm this crash. Happens when you choose BoP world generator type. No crash with RTG world type. Forge 1492

commented

It never occurred to me that it might be because of the wrong world type being selected - nice one!

commented

But shouldn't RTG do nothing when not set to world type?

commented

yes i had BOP world type set. But i agree that this should not happen.

commented

Fixed in fe5e4f4.

commented

Good job @whichonespink44! ๐Ÿ‘