Add support for the Vampire Forest from Vampirism
whichonespink44 opened this issue ยท 7 comments
I've opened an issue on the Vampirism tracker: TeamLapen/Vampirism#56
I've added partial support for Vampirism in the vampirism-support branch, but whilst the Vampire Forest is generating, the Vampire Castle is not.
I have no special knowledge on findBiomePosition - I've never had to deal with it in any way. Two possible performance issues - if the third integer parameter (the size) is really big, that will induce the GenLayer IntCache to initialize and keep around a large object. Second (probably irrelevant) - after finding a ChunkPosition, I think you should break out of the loop.
Added in 3f4a88a.
The minimum required version of Vampirism has been set to 0.7.8.5, which hasn't been released yet.
@maxanier will be changing the way Vampirism compares biomes in v0.7.8.5, and this change is necessary in order for RTG to be able to generate Vampire Castles.
Also...
@Zeno410 Part of this implementation involved replacing the stub we had for WorldChunkManagerRTG#findBiomePosition with the vanilla logic. I've done some basic testing in a few worlds, and it didn't seem to cause any problems, but you might want to have a quick look to see if anything looks like it might give us trouble down the line. If we need to, we can revert back to the stub, as it's not actually required for compatibility - it just allows some debugging commands from Vampirism to work correctly.
Just wanted to mention: WorldChunkManagerRTG#findBiomePosition is not compulsory for compatibility, but very recommend, since Vampirism uses it to find possible castle positions on world creation. Otherwise the "blood eye" does not work and Vampirism has to check every newly generated Vampire Forest chunk for a possible position.